Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search items #888

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: Search items #888

merged 1 commit into from
Feb 5, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Feb 5, 2024

This PR fixes the search-matching logic.

Screen.Recording.2024-02-05.at.17.00.14.mov

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3c3df0a
Status: ✅  Deploy successful!
Preview URL: https://db425fd7.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-search.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/search/dcl-sdk-7.3.42-7790162998.commit-529cf31.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/search/dcl-sdk-commands-7.3.42-7790162998.commit-529cf31.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/search/@dcl/inspector/dcl-inspector-7.3.42-7790162998.commit-529cf31.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/search-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/search

@cyaiox cyaiox merged commit 8c58bd1 into main Feb 5, 2024
8 checks passed
@cyaiox cyaiox deleted the fix/search branch February 5, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants