Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track when adding/removing components: lock and hide #883

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Jan 31, 2024

This PR adds tracking for adding/removing the components: Lock and Hide.

Closes: decentraland/sdk#1074

Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82b55e1
Status: ✅  Deploy successful!
Preview URL: https://1578a6fa.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-track-lock-hide-compone.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/track-lock-hide-components/dcl-sdk-7.3.41-7731577748.commit-40434cc.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/track-lock-hide-components/dcl-sdk-commands-7.3.41-7731577748.commit-40434cc.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/track-lock-hide-components/@dcl/inspector/dcl-inspector-7.3.41-7731577748.commit-40434cc.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/track-lock-hide-components-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/track-lock-hide-components

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e86ba6) 67.42% compared to head (82b55e1) 67.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files         519      519           
  Lines       16063    16063           
  Branches     2047     2047           
=======================================
  Hits        10830    10830           
  Misses       4904     4904           
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyaiox cyaiox enabled auto-merge (squash) January 31, 2024 21:27
@cyaiox cyaiox merged commit fef3a76 into main Jan 31, 2024
10 checks passed
@cyaiox cyaiox deleted the feat/track-lock-hide-components branch January 31, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tracking events
2 participants