Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add smart-item asset badge #774

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Oct 9, 2023

This PR adds the smart item asset badge and background color.

image

@cyaiox cyaiox marked this pull request as ready for review October 9, 2023 21:40
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3603b3f
Status: ✅  Deploy successful!
Preview URL: https://e7a6cbc8.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-update-smart-items-indi.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-smart-items-indicator/dcl-sdk-7.3.20-6469656732.commit-764bd3b.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-smart-items-indicator/dcl-sdk-commands-7.3.20-6469656732.commit-764bd3b.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-smart-items-indicator/@dcl/inspector/dcl-inspector-7.3.20-6469656732.commit-764bd3b.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/update-smart-items-indicator-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/update-smart-items-indicator

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ad4ad4b) 71.51% compared to head (3603b3f) 71.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files         390      390           
  Lines       12810    12810           
  Branches     1734     1734           
=======================================
  Hits         9161     9161           
  Misses       3441     3441           
  Partials      208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyaiox cyaiox force-pushed the feat/update-smart-items-indicator branch from e1e7ba2 to 3603b3f Compare October 10, 2023 12:59
@cyaiox cyaiox enabled auto-merge (squash) October 10, 2023 13:00
@cyaiox cyaiox merged commit 3197b21 into main Oct 10, 2023
10 checks passed
@cyaiox cyaiox deleted the feat/update-smart-items-indicator branch October 10, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants