Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attach/detach, loop animation, stop animation/sound #770

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Oct 5, 2023

This PR adds support for the attach_to_player and detach_from_player actions, adds support for the loop property in play_animation, and adds support for the new stop_animation and stop_sound actions.

@cazala cazala requested a review from cyaiox October 5, 2023 17:26
)

return (
<div className="PlaySoundActionContainer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="PlaySoundActionContainer">
<div className="PlayAnimationActionContainer">

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 30d92a0
Status: ✅  Deploy successful!
Preview URL: https://a494c2c9.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-attach-detach-player.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/attach-detach-player/dcl-sdk-7.3.19-6423890049.commit-5b5fea5.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/attach-detach-player/dcl-sdk-commands-7.3.19-6423890049.commit-5b5fea5.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/attach-detach-player/@dcl/inspector/dcl-inspector-7.3.19-6423890049.commit-5b5fea5.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/attach-detach-player-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/attach-detach-player

@cazala cazala enabled auto-merge (squash) October 5, 2023 20:11
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (5f33809) 71.47% compared to head (30d92a0) 71.16%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   71.47%   71.16%   -0.31%     
==========================================
  Files         382      388       +6     
  Lines       12680    12732      +52     
  Branches     1703     1709       +6     
==========================================
- Hits         9063     9061       -2     
- Misses       3416     3464      +48     
- Partials      201      207       +6     
Files Coverage Δ
...ges/@dcl/inspector/src/lib/sdk/components/index.ts 100.00% <100.00%> (ø)
...tityInspector/ActionInspector/TweenAction/utils.ts 0.00% <0.00%> (ø)
...ector/ActionInspector/PlayAnimationAction/index.ts 0.00% <0.00%> (ø)
...ityInspector/VisibilityComponentInspector/index.ts 0.00% <0.00%> (ø)
...@dcl/inspector/src/lib/sdk/operations/add-asset.ts 34.96% <75.00%> (-1.17%) ⬇️
...ityInspector/VisibilityComponentInspector/types.ts 0.00% <0.00%> (ø)
...ector/ActionInspector/PlayAnimationAction/utils.ts 0.00% <0.00%> (ø)
...ector/ActionInspector/PlayAnimationAction/types.ts 0.00% <0.00%> (ø)
...omponents/EntityInspector/ActionInspector/utils.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala merged commit 90f5538 into main Oct 5, 2023
8 of 10 checks passed
@cazala cazala deleted the feat/attach-detach-player branch October 5, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants