-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: attach/detach, loop animation, stop animation/sound #770
Conversation
...r/src/components/EntityInspector/ActionInspector/PlayAnimationAction/PlayAnimationAction.tsx
Show resolved
Hide resolved
) | ||
|
||
return ( | ||
<div className="PlaySoundActionContainer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div className="PlaySoundActionContainer"> | |
<div className="PlayAnimationActionContainer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👍
...r/src/components/EntityInspector/ActionInspector/PlayAnimationAction/PlayAnimationAction.css
Outdated
Show resolved
Hide resolved
Deploying with Cloudflare Pages
|
Test this pull request
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
- Coverage 71.47% 71.16% -0.31%
==========================================
Files 382 388 +6
Lines 12680 12732 +52
Branches 1703 1709 +6
==========================================
- Hits 9063 9061 -2
- Misses 3416 3464 +48
- Partials 201 207 +6
☔ View full report in Codecov by Sentry. |
This PR adds support for the
attach_to_player
anddetach_from_player
actions, adds support for theloop
property inplay_animation
, and adds support for the newstop_animation
andstop_sound
actions.