Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vscode support #768

Merged
merged 7 commits into from
Oct 8, 2023
Merged

feat: vscode support #768

merged 7 commits into from
Oct 8, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Oct 5, 2023

Add support for VSCode

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e5e3577
Status: ✅  Deploy successful!
Preview URL: https://5eca4b15.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-vscode-support.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/vscode-support/dcl-sdk-7.3.19-6449466729.commit-8af0183.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/vscode-support/dcl-sdk-commands-7.3.19-6449466729.commit-8af0183.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/vscode-support/@dcl/inspector/dcl-inspector-7.3.19-6449466729.commit-8af0183.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/vscode-support-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/vscode-support

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9b97e80) 71.64% compared to head (e5e3577) 71.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   71.64%   71.64%           
=======================================
  Files         388      388           
  Lines       12770    12770           
  Branches     1728     1728           
=======================================
  Hits         9149     9149           
  Misses       3415     3415           
  Partials      206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala force-pushed the feat/vscode-support branch from 372d358 to 87a696d Compare October 5, 2023 20:20
@cazala cazala enabled auto-merge (squash) October 6, 2023 19:59
@cazala cazala merged commit bf7aa87 into main Oct 8, 2023
10 checks passed
@cazala cazala deleted the feat/vscode-support branch October 8, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants