Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: audio source #761

Merged
merged 15 commits into from
Oct 4, 2023
Merged

feat: audio source #761

merged 15 commits into from
Oct 4, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Oct 3, 2023

This PR adds support for AudioSource component and play_sound action

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ee9612
Status: ✅  Deploy successful!
Preview URL: https://0212743c.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-audio-source.js-sdk-toolchain.pages.dev

View logs

@cazala cazala marked this pull request as ready for review October 3, 2023 21:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/audio-source/dcl-sdk-7.3.18-6406789423.commit-18b5a9e.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/audio-source/dcl-sdk-commands-7.3.18-6406789423.commit-18b5a9e.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/audio-source/@dcl/inspector/dcl-inspector-7.3.18-6406789423.commit-18b5a9e.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/audio-source-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/audio-source

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (44bc935) 72.04% compared to head (1ee9612) 71.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   72.04%   71.27%   -0.77%     
==========================================
  Files         375      381       +6     
  Lines       12490    12587      +97     
  Branches     1708     1701       -7     
==========================================
- Hits         8998     8972      -26     
- Misses       3297     3414     +117     
- Partials      195      201       +6     
Files Coverage Δ
...@dcl/inspector/src/lib/data-layer/host/fs-utils.ts 90.90% <100.00%> (ø)
...ges/@dcl/inspector/src/lib/sdk/components/index.ts 100.00% <100.00%> (ø)
packages/@dcl/inspector/src/lib/sdk/drag-drop.ts 100.00% <100.00%> (ø)
...@dcl/inspector/src/lib/sdk/operations/add-child.ts 100.00% <100.00%> (+29.59%) ⬆️
.../inspector/src/lib/sdk/operations/add-component.ts 86.36% <100.00%> (ø)
.../src/components/EntityInspector/TextField/types.ts 0.00% <0.00%> (ø)
...Inspector/ActionInspector/PlaySoundAction/index.ts 0.00% <0.00%> (ø)
...ents/EntityInspector/AudioSourceInspector/index.ts 0.00% <0.00%> (ø)
...ector/src/components/ProjectAssetExplorer/types.ts 0.00% <0.00%> (ø)
...Inspector/ActionInspector/PlaySoundAction/utils.ts 0.00% <0.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala force-pushed the feat/audio-source branch from ba620a9 to b75df8a Compare October 4, 2023 02:48
@cazala cazala force-pushed the feat/audio-source branch from 7fdfb67 to 2179137 Compare October 4, 2023 11:43
Copy link
Contributor

@cyaiox cyaiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job! left a small suggestion but is approved

@cazala cazala enabled auto-merge (squash) October 4, 2023 13:35
@cazala cazala merged commit beb3642 into main Oct 4, 2023
@cazala cazala deleted the feat/audio-source branch October 4, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants