-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: audio source #761
feat: audio source #761
Conversation
Deploying with Cloudflare Pages
|
Test this pull request
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 72.04% 71.27% -0.77%
==========================================
Files 375 381 +6
Lines 12490 12587 +97
Branches 1708 1701 -7
==========================================
- Hits 8998 8972 -26
- Misses 3297 3414 +117
- Partials 195 201 +6
☔ View full report in Codecov by Sentry. |
ba620a9
to
b75df8a
Compare
7fdfb67
to
2179137
Compare
packages/@dcl/inspector/src/components/EntityInspector/ActionInspector/PlaySoundAction/types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing job! left a small suggestion but is approved
This PR adds support for
AudioSource
component andplay_sound
action