Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger conditions on drag n drop #742

Merged
merged 3 commits into from
Sep 20, 2023
Merged

fix: trigger conditions on drag n drop #742

merged 3 commits into from
Sep 20, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 20, 2023

This PR fixes conditions by replacing {selfEntity} on drag n dropped items. It also hides the operation dropdown when there are less than 2 conditions, since it's not necessary on that scenario.

@cazala cazala requested a review from cyaiox September 20, 2023 19:17
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2f7d56
Status: ✅  Deploy successful!
Preview URL: https://67410ec7.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-conditions.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/conditions/dcl-sdk-7.3.16-6253262416.commit-82b1675.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/conditions/dcl-sdk-commands-7.3.16-6253262416.commit-82b1675.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/conditions/@dcl/inspector/dcl-inspector-7.3.16-6253262416.commit-82b1675.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/conditions-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/conditions

@cazala cazala enabled auto-merge (squash) September 20, 2023 19:23
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% ⚠️

Comparison is base (0785c75) 72.61% compared to head (b74779c) 72.60%.

❗ Current head b74779c differs from pull request most recent head e2f7d56. Consider uploading reports for the commit e2f7d56 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   72.61%   72.60%   -0.01%     
==========================================
  Files         364      364              
  Lines       12135    12139       +4     
  Branches     1644     1644              
==========================================
+ Hits         8812     8814       +2     
- Misses       3136     3138       +2     
  Partials      187      187              
Files Changed Coverage Δ
...@dcl/inspector/src/lib/sdk/operations/add-child.ts 91.22% <50.00%> (-3.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala merged commit dea8a53 into main Sep 20, 2023
@cazala cazala deleted the fix/conditions branch September 20, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants