Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use outline instead of bounding box #737

Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat: use outline instead of bounding box #737

merged 4 commits into from
Sep 15, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 15, 2023

Before:
Screenshot 2023-09-14 at 16 55 52

After:

outline-instead-of-bounding-box.mp4

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08115a5
Status: ✅  Deploy successful!
Preview URL: https://c18b68fc.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-outline.js-sdk-toolchain.pages.dev

View logs

@cazala cazala enabled auto-merge (squash) September 15, 2023 17:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/outline/dcl-sdk-7.3.15-6201425917.commit-c6f3557.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/outline/dcl-sdk-commands-7.3.15-6201425917.commit-c6f3557.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/outline/@dcl/inspector/dcl-inspector-7.3.15-6201425917.commit-c6f3557.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/outline-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/outline

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 64.44% and project coverage change: -0.04% ⚠️

Comparison is base (767716e) 73.23% compared to head (3822eda) 73.20%.
Report is 1 commits behind head on main.

❗ Current head 3822eda differs from pull request most recent head 08115a5. Consider uploading reports for the commit 08115a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   73.23%   73.20%   -0.04%     
==========================================
  Files         356      356              
  Lines       11894    11933      +39     
  Branches     1608     1612       +4     
==========================================
+ Hits         8711     8735      +24     
- Misses       3004     3019      +15     
  Partials      179      179              
Files Changed Coverage Δ
...babylon/decentraland/editorComponents/selection.ts 76.71% <57.89%> (-17.74%) ⬇️
...abylon/decentraland/sdkComponents/mesh-renderer.ts 67.05% <100.00%> (+0.79%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants