Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @dcl/protocol to add TriggerSceneEmote restricted action #691

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

pbosio
Copy link
Contributor

@pbosio pbosio commented Jul 19, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ec3ba4
Status: ✅  Deploy successful!
Preview URL: https://722890bb.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-triggersceneemote-restr.js-sdk-toolchain.pages.dev

View logs

package.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/triggersceneemote-restrictedaction/dcl-sdk-7.3.2-5644525851.commit-a396b3e.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/triggersceneemote-restrictedaction/dcl-sdk-commands-7.3.2-5644525851.commit-a396b3e.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/triggersceneemote-restrictedaction/@dcl/inspector/dcl-inspector-7.3.2-5644525851.commit-a396b3e.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/triggersceneemote-restrictedaction-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/triggersceneemote-restrictedaction

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4a5c96a) 73.77% compared to head (bec17ac) 73.77%.

❗ Current head bec17ac differs from pull request most recent head 5ec3ba4. Consider uploading reports for the commit 5ec3ba4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files         312      312           
  Lines       10470    10470           
  Branches     1361     1361           
=======================================
  Hits         7724     7724           
  Misses       2612     2612           
  Partials      134      134           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pbosio pbosio changed the title feat: add TriggerSceneEmote restricted action chore: bump @dcl/protocol to add TriggerSceneEmote restricted action Jul 21, 2023
@pbosio pbosio marked this pull request as ready for review July 21, 2023 17:31
@pbosio pbosio enabled auto-merge (squash) July 24, 2023 12:00
@pbosio pbosio merged commit 7cd3d38 into main Jul 24, 2023
@pbosio pbosio deleted the feat/triggersceneemote-restrictedaction branch July 24, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants