Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more e2e tests #672

Merged
merged 2 commits into from
Jun 30, 2023
Merged

chore: add more e2e tests #672

merged 2 commits into from
Jun 30, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Jun 29, 2023

This PR adds e2e test for two use cases: dragging an asset from the file system into the canvas and making sure it is added to the entity tree, and also from the builder assets

@cazala cazala force-pushed the chore/add-more-e2e-tests branch from 0f74ab4 to 59ac6a4 Compare June 29, 2023 19:30
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59ac6a4
Status: ✅  Deploy successful!
Preview URL: https://872056d1.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-add-more-e2e-tests.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/add-more-e2e-tests/dcl-sdk-7.2.5-5415984144.commit-47fa1ec.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/add-more-e2e-tests/dcl-sdk-commands-7.2.5-5415984144.commit-47fa1ec.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/add-more-e2e-tests/@dcl/inspector/dcl-inspector-7.2.5-5415984144.commit-47fa1ec.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/add-more-e2e-tests-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/add-more-e2e-tests

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d72f900) 73.37% compared to head (59ac6a4) 73.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   73.37%   73.37%           
=======================================
  Files         296      296           
  Lines        9815     9815           
  Branches     1277     1277           
=======================================
  Hits         7202     7202           
  Misses       2491     2491           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cazala cazala requested a review from nicoecheza June 30, 2023 18:50
@nicoecheza nicoecheza merged commit 3e49c5d into main Jun 30, 2023
@nicoecheza nicoecheza deleted the chore/add-more-e2e-tests branch June 30, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants