Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try/catch datalayer init and log composites #663

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

gonpombo8
Copy link
Contributor

No description provided.

@gonpombo8 gonpombo8 force-pushed the feat/try-catch-data-layer branch from b1e21a4 to ae3f2b2 Compare June 21, 2023 20:54
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae3f2b2
Status: ✅  Deploy successful!
Preview URL: https://94cb5f6d.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-try-catch-data-layer.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/try-catch-data-layer/dcl-sdk-7.2.4-5338844989.commit-194761d.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/try-catch-data-layer/dcl-sdk-commands-7.2.4-5338844989.commit-194761d.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/try-catch-data-layer/@dcl/inspector/dcl-inspector-7.2.4-5338844989.commit-194761d.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/try-catch-data-layer-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/try-catch-data-layer

@gonpombo8 gonpombo8 marked this pull request as ready for review June 21, 2023 20:59
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03 ⚠️

Comparison is base (96b8298) 74.18% compared to head (b1e21a4) 74.16%.

❗ Current head b1e21a4 differs from pull request most recent head ae3f2b2. Consider uploading reports for the commit ae3f2b2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   74.18%   74.16%   -0.03%     
==========================================
  Files         289      289              
  Lines        9526     9530       +4     
  Branches     1273     1273              
==========================================
+ Hits         7067     7068       +1     
- Misses       2339     2341       +2     
- Partials      120      121       +1     
Impacted Files Coverage Δ
...ages/@dcl/sdk-commands/src/commands/start/index.ts 28.00% <20.00%> (-0.87%) ⬇️
...lib/data-layer/host/utils/fs-composite-provider.ts 82.05% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonpombo8 gonpombo8 merged commit 4f64248 into main Jun 21, 2023
@gonpombo8 gonpombo8 deleted the feat/try-catch-data-layer branch June 21, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant