Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linter to inspector #659

Merged
merged 2 commits into from
Jun 22, 2023
Merged

add linter to inspector #659

merged 2 commits into from
Jun 22, 2023

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Jun 20, 2023

Lint config was missing for all .tsx files.
Add this extension and fix all the issues that raised

@gonpombo8 gonpombo8 marked this pull request as ready for review June 20, 2023 20:43
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8b1c04
Status: ✅  Deploy successful!
Preview URL: https://618a9aa1.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-linter-to-inspector.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/linter-to-inspector/dcl-sdk-7.2.5-5348162380.commit-1b24316.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/linter-to-inspector/dcl-sdk-commands-7.2.5-5348162380.commit-1b24316.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/linter-to-inspector/@dcl/inspector/dcl-inspector-7.2.5-5348162380.commit-1b24316.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/linter-to-inspector-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/linter-to-inspector

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dbb6d9f) 74.17% compared to head (eae2372) 74.18%.

❗ Current head eae2372 differs from pull request most recent head b8b1c04. Consider uploading reports for the commit b8b1c04 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   74.17%   74.18%           
=======================================
  Files         289      289           
  Lines        9534     9525    -9     
  Branches     1274     1273    -1     
=======================================
- Hits         7072     7066    -6     
+ Misses       2341     2339    -2     
+ Partials      121      120    -1     
Impacted Files Coverage Δ
...ector/src/lib/babylon/decentraland/SceneContext.ts 73.33% <ø> (-0.15%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonpombo8 gonpombo8 force-pushed the add/linter-to-inspector branch from eae2372 to b8b1c04 Compare June 22, 2023 16:45
@gonpombo8 gonpombo8 merged commit e063cf0 into main Jun 22, 2023
@gonpombo8 gonpombo8 deleted the add/linter-to-inspector branch June 22, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant