Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user preferences panel #653

Merged
merged 1 commit into from
Jun 19, 2023
Merged

feat: user preferences panel #653

merged 1 commit into from
Jun 19, 2023

Conversation

AN-DCL
Copy link
Contributor

@AN-DCL AN-DCL commented Jun 19, 2023

Closes decentraland/sdk#856.

  1. Convert camera preferences button & panel into general preferences button & panel.
  2. Preferences panel contains preferences for inversion of camera rotation & autosaving.
  3. Add tooltips to toolbar's buttons.
  4. Ensure that toolbar's save button works correctly when autosave is enabled.
  5. Ensure that data layer's autosave procedure uses fresh preferences.

@github-actions
Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/preferences-panel/dcl-sdk-7.2.4-5310990524.commit-7a58e37.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/preferences-panel/dcl-sdk-commands-7.2.4-5310990524.commit-7a58e37.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/preferences-panel/@dcl/inspector/dcl-inspector-7.2.4-5310990524.commit-7a58e37.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/preferences-panel-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=preferences-panel

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.48 🎉

Comparison is base (201e11d) 73.42% compared to head (affb918) 73.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   73.42%   73.91%   +0.48%     
==========================================
  Files         274      274              
  Lines        9171     9186      +15     
  Branches     1238     1245       +7     
==========================================
+ Hits         6734     6790      +56     
+ Misses       2319     2279      -40     
+ Partials      118      117       -1     
Impacted Files Coverage Δ
...pector/src/components/Toolbar/Preferences/index.ts 0.00% <0.00%> (ø)
...ackages/@dcl/inspector/src/hooks/editor/useSave.ts 37.50% <0.00%> (-5.36%) ⬇️
...dcl/inspector/src/lib/logic/preferences/manager.ts 59.09% <40.00%> (-5.62%) ⬇️
...l/inspector/src/lib/data-layer/host/rpc-methods.ts 69.76% <100.00%> (+1.73%) ⬆️
...r/src/lib/data-layer/host/utils/composite-dirty.ts 90.67% <100.00%> (+4.23%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AN-DCL AN-DCL merged commit aff38fe into main Jun 19, 2023
@AN-DCL AN-DCL deleted the preferences-panel branch June 19, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User preferences panel
2 participants