Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #651

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Fix build #651

merged 4 commits into from
Jun 15, 2023

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Jun 15, 2023

Fix build and deploy to s3.

React-Ecs has @dcl/ecs dependency which was pointing to a version that doesn't exists file:../ecs.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc08a06
Status: ✅  Deploy successful!
Preview URL: https://062155c9.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-build.js-sdk-toolchain.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (46d00ce) 73.28% compared to head (c89e6e4) 73.31%.

❗ Current head c89e6e4 differs from pull request most recent head fc08a06. Consider uploading reports for the commit fc08a06 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   73.28%   73.31%   +0.02%     
==========================================
  Files         274      274              
  Lines        9168     9165       -3     
  Branches     1239     1237       -2     
==========================================
  Hits         6719     6719              
+ Misses       2329     2327       -2     
+ Partials      120      119       -1     
Impacted Files Coverage Δ
...ages/@dcl/sdk-commands/src/commands/start/index.ts 28.86% <0.00%> (+0.86%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/build/dcl-sdk-7.2.1-5282764196.commit-204878a.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/build/dcl-sdk-commands-7.2.2-5282764196.commit-204878a.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/build/@dcl/inspector/dcl-inspector-7.2.2-5282764196.commit-204878a.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/build-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/build

@gonpombo8 gonpombo8 changed the title wip Fix build Jun 15, 2023
@gonpombo8 gonpombo8 marked this pull request as ready for review June 15, 2023 19:18
@gonpombo8 gonpombo8 enabled auto-merge (squash) June 15, 2023 19:23
@gonpombo8 gonpombo8 merged commit fee7c5a into main Jun 15, 2023
@gonpombo8 gonpombo8 deleted the fix/build branch June 15, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants