Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete asset from context menu for asset tiles #638

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Jun 8, 2023

closes decentraland/sdk#826

🤖 Generated by Copilot at d8f1d4e

Refactored the ProjectView component to use the Tile component for rendering assets and folders in the project explorer. Added the Tile component, which is a functional component that handles the icon, name, context menu, and drag and drop functionality of the assets and folders. Removed the obsolete NodeView component and its styles.

@nicoecheza nicoecheza force-pushed the feat/delete-asset branch from d8f1d4e to 438bbbf Compare June 8, 2023 16:41
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6465a9
Status: ✅  Deploy successful!
Preview URL: https://78dcc4fc.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-delete-asset.js-sdk-toolchain.pages.dev

View logs

@nicoecheza nicoecheza force-pushed the feat/delete-asset branch 2 times, most recently from f6465a9 to d763167 Compare June 8, 2023 16:42
@nicoecheza nicoecheza force-pushed the feat/delete-asset branch from d763167 to 847a0f4 Compare June 8, 2023 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/delete-asset/dcl-sdk-7.2.1-5213672430.commit-49b680b.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/delete-asset/dcl-sdk-commands-7.2.1-5213672430.commit-49b680b.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/delete-asset/@dcl/inspector/dcl-inspector-7.2.1-5213672430.commit-49b680b.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/delete-asset-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/delete-asset

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -11.91 ⚠️

Comparison is base (cff9a1d) 85.73% compared to head (d8f1d4e) 73.83%.

❗ Current head d8f1d4e differs from pull request most recent head 847a0f4. Consider uploading reports for the commit 847a0f4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #638       +/-   ##
===========================================
- Coverage   85.73%   73.83%   -11.91%     
===========================================
  Files         129      272      +143     
  Lines        3856     9041     +5185     
  Branches      644     1210      +566     
===========================================
+ Hits         3306     6675     +3369     
- Misses        507     2248     +1741     
- Partials       43      118       +75     
Impacted Files Coverage Δ
.../src/components/ProjectAssetExplorer/Tile/index.ts 0.00% <0.00%> (ø)
.../src/components/ProjectAssetExplorer/Tile/types.ts 0.00% <0.00%> (ø)

... and 141 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicoecheza nicoecheza merged commit efc0f49 into main Jun 9, 2023
@nicoecheza nicoecheza deleted the feat/delete-asset branch June 9, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset folder view: add context menu with "Delete asset" option to asset tiles
2 participants