Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entity node + various fixes #635

Merged
merged 16 commits into from
Jun 9, 2023
Merged

Remove entity node + various fixes #635

merged 16 commits into from
Jun 9, 2023

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Jun 7, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 480605d
Status: ✅  Deploy successful!
Preview URL: https://55b691b6.js-sdk-toolchain.pages.dev
Branch Preview URL: https://remove-entity-node.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/entity-node/dcl-sdk-7.2.1-5224521994.commit-179c273.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/entity-node/dcl-sdk-commands-7.2.1-5224521994.commit-179c273.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/entity-node/@dcl/inspector/dcl-inspector-7.2.1-5224521994.commit-179c273.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/remove/entity-node-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=remove/entity-node

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 82.65% and project coverage change: -0.62 ⚠️

Comparison is base (efc0f49) 73.83% compared to head (480605d) 73.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   73.83%   73.21%   -0.62%     
==========================================
  Files         272      274       +2     
  Lines        9040     9055      +15     
  Branches     1210     1215       +5     
==========================================
- Hits         6675     6630      -45     
- Misses       2247     2305      +58     
- Partials      118      120       +2     
Impacted Files Coverage Δ
packages/@dcl/ecs/src/engine/types.ts 100.00% <ø> (ø)
packages/@dcl/ecs/src/runtime/types.ts 100.00% <ø> (ø)
.../@dcl/inspector/src/hooks/sdk/useComponentValue.ts 24.63% <0.00%> (+0.95%) ⬆️
packages/@dcl/inspector/src/hooks/sdk/useTree.ts 0.00% <0.00%> (ø)
packages/@dcl/inspector/src/lib/sdk/context.ts 45.67% <ø> (+2.00%) ⬆️
...s/src/commands/start/server/file-watch-notifier.ts 31.81% <14.28%> (-1.52%) ⬇️
...@dcl/inspector/src/lib/sdk/operations/add-child.ts 50.00% <28.57%> (-11.54%) ⬇️
.../inspector/src/lib/sdk/operations/remove-entity.ts 47.05% <33.33%> (+2.05%) ⬆️
...dcl/inspector/src/lib/sdk/operations/set-parent.ts 70.00% <33.33%> (+22.63%) ⬆️
...src/lib/sdk/operations/remove-selected-entities.ts 61.53% <50.00%> (ø)
... and 19 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonpombo8 gonpombo8 force-pushed the remove/entity-node branch 4 times, most recently from 94b1777 to cde716d Compare June 7, 2023 20:44
@gonpombo8 gonpombo8 changed the title Remove/entity node Remove entity node + various fixes Jun 8, 2023
@gonpombo8 gonpombo8 marked this pull request as ready for review June 8, 2023 17:55
@gonpombo8 gonpombo8 force-pushed the remove/entity-node branch from de8fe34 to 5e0ba81 Compare June 8, 2023 17:56
@gonpombo8 gonpombo8 force-pushed the remove/entity-node branch from 5e0ba81 to 8aed7bb Compare June 9, 2023 15:22
@gonpombo8 gonpombo8 requested a review from nicoecheza June 9, 2023 17:08
@gonpombo8 gonpombo8 merged commit 5f67953 into main Jun 9, 2023
@gonpombo8 gonpombo8 deleted the remove/entity-node branch June 9, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in the Inspector don't show in preview Inspector Bugs Easily reference entities from code
2 participants