Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gltf removal #631

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix: Gltf removal #631

merged 1 commit into from
Jun 7, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Jun 7, 2023

closes decentraland/sdk#819

🤖 Generated by Copilot at 4130007

This pull request improves the type safety, readability, and consistency of the component removal operation in the inspector, by using component definitions instead of numeric ids, and by refactoring some functions. It affects the files GltfInspector.tsx, TransformInspector.tsx, gltf-container.ts, and remove-component.ts.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48cbad7
Status: ✅  Deploy successful!
Preview URL: https://b4a86c1a.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-gltf-removal.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/gltf-removal/dcl-sdk-7.2.1-5202262277.commit-1305374.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/gltf-removal/dcl-sdk-commands-7.2.1-5202262277.commit-1305374.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/gltf-removal/@dcl/inspector/dcl-inspector-7.2.1-5202262277.commit-1305374.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/gltf-removal-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/gltf-removal

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (3d91501) 73.66% compared to head (48cbad7) 73.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   73.66%   73.64%   -0.02%     
==========================================
  Files         270      270              
  Lines        9029     9023       -6     
  Branches     1192     1194       +2     
==========================================
- Hits         6651     6645       -6     
  Misses       2262     2262              
  Partials      116      116              
Impacted Files Coverage Δ
...bylon/decentraland/sdkComponents/gltf-container.ts 28.62% <100.00%> (ø)
...spector/src/lib/sdk/operations/remove-component.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicoecheza nicoecheza requested a review from AN-DCL June 7, 2023 16:26
@AN-DCL AN-DCL merged commit 9ccb73f into main Jun 7, 2023
@AN-DCL AN-DCL deleted the fix/gltf-removal branch June 7, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of entity that has children doesn't work correctly
2 participants