Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add assets folder structure #629

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Jun 6, 2023

closes decentraland/sdk#783
closes decentraland/sdk#825

🤖 Generated by Copilot at 418ff82

Refactored and improved the inspector's components, hooks, and data layer modules to handle asset paths more consistently and reliably, and to support hiding entities from the hierarchy view. Added a new method and message type to the data layer protocol to retrieve the project path. Updated the README and the CSS files accordingly.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f21066
Status: ✅  Deploy successful!
Preview URL: https://69665e05.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-assets-folder-structure.js-sdk-toolchain.pages.dev

View logs

@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch from a617662 to c03aa0b Compare June 6, 2023 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/assets-folder-structure/dcl-sdk-7.2.1-5225827016.commit-04ff51f.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/assets-folder-structure/dcl-sdk-commands-7.2.1-5225827016.commit-04ff51f.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/assets-folder-structure/@dcl/inspector/dcl-inspector-7.2.1-5225827016.commit-04ff51f.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/assets-folder-structure-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/assets-folder-structure

@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch 4 times, most recently from e398c69 to 75caab2 Compare June 6, 2023 17:47
@nicoecheza nicoecheza marked this pull request as ready for review June 6, 2023 17:48
@nicoecheza nicoecheza requested a review from gonpombo8 June 6, 2023 17:51
@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch from 75caab2 to c66ea9a Compare June 6, 2023 18:17
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 79.16% and project coverage change: +0.07 🎉

Comparison is base (5f67953) 73.21% compared to head (0f21066) 73.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   73.21%   73.29%   +0.07%     
==========================================
  Files         274      274              
  Lines        9055     9139      +84     
  Branches     1215     1229      +14     
==========================================
+ Hits         6630     6698      +68     
- Misses       2305     2321      +16     
  Partials      120      120              
Impacted Files Coverage Δ
packages/@dcl/inspector/src/hooks/sdk/useTree.ts 0.00% <0.00%> (ø)
...ackages/@dcl/inspector/src/lib/data-layer/types.ts 0.00% <0.00%> (ø)
...l/sdk-commands/src/commands/start/data-layer/fs.ts 8.33% <0.00%> (-0.76%) ⬇️
...l/inspector/src/lib/data-layer/host/rpc-methods.ts 67.47% <38.09%> (-3.58%) ⬇️
...dcl/inspector/src/lib/data-layer/host/undo-redo.ts 95.27% <50.00%> (+0.03%) ⬆️
...r/src/lib/data-layer/host/utils/composite-dirty.ts 86.44% <75.00%> (ø)
...@dcl/inspector/src/lib/data-layer/host/fs-utils.ts 91.11% <83.33%> (-4.73%) ⬇️
...es/@dcl/inspector/src/lib/data-layer/host/scene.ts 96.00% <94.73%> (-1.37%) ⬇️
...ector/src/lib/babylon/decentraland/SceneContext.ts 86.82% <100.00%> (+0.06%) ⬆️
...ector/src/lib/data-layer/client/feeded-local-fs.ts 81.92% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch 3 times, most recently from 9d200a7 to 77113a1 Compare June 8, 2023 14:32
@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch from 77113a1 to 2a6e1ae Compare June 9, 2023 14:37
@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch from ee0a883 to 6df67fb Compare June 9, 2023 17:32
@nicoecheza nicoecheza enabled auto-merge (squash) June 9, 2023 20:04
@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch from 418ff82 to e61f2cb Compare June 9, 2023 20:06
@nicoecheza nicoecheza force-pushed the feat/assets-folder-structure branch from e61f2cb to 0f21066 Compare June 9, 2023 20:30
@nicoecheza nicoecheza merged commit 830bc74 into main Jun 9, 2023
@nicoecheza nicoecheza deleted the feat/assets-folder-structure branch June 9, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset import: do not create a folder for asset imported from local FS Assets folder's structure
2 participants