feat: make panels resizable #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
bc74c7b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ebdbd75a.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-panels.js-sdk-toolchain.pages.dev |
Test this pull request
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
+ Coverage 72.84% 73.24% +0.39%
==========================================
Files 267 266 -1
Lines 8816 8813 -3
Branches 1153 1155 +2
==========================================
+ Hits 6422 6455 +33
+ Misses 2277 2243 -34
+ Partials 117 115 -2
☔ View full report in Codecov by Sentry. |
nicoecheza
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes decentraland/sdk#763
In this PR I made all the panels resizable, moved the EntityInspector to a new panel on the right, and changed the styles of the Hierarchy and EntityInspector components to match the Assets footer styles (vscodish)
resize-panels.mp4
🤖 Generated by Copilot at b2e294d
This pull request improves the inspector UI by replacing the custom Resizable component with the
react-resizable-panelslibrary, updating the layout and styling of the inspector panels, and adding some hooks and attributes to enhance the functionality and integration of the inspector UI. It also adds some unit tests for the new useWindowSize hook, which returns the window size. It modifies several files in thepackages/@dcl/inspectorfolder, such aspackage.json,package-lock.json,App.tsx,App.css,Assets.tsx,Assets.css,EntityInspector.tsx,EntityInspector.css,Hierarchy.tsx,Hierarchy.css,useWindowSize.ts, anduseWindowSize.spec.ts. It also deletes the files related to the Resizable component, such asResizable.tsx,Resizable.css,index.ts, andtypes.ts.