Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set-parent.ts #614

Merged
merged 2 commits into from
May 31, 2023
Merged

Update set-parent.ts #614

merged 2 commits into from
May 31, 2023

Conversation

menduz
Copy link
Member

@menduz menduz commented May 29, 2023

It is creating a new component every time

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81b71e8
Status: ✅  Deploy successful!
Preview URL: https://daaca222.js-sdk-toolchain.pages.dev
Branch Preview URL: https://menduz-patch-1.js-sdk-toolchain.pages.dev

View logs

menduz and others added 2 commits May 31, 2023 16:54
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/menduz-patch-1/dcl-sdk-7.1.18-5137100703.commit-39b7113.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/menduz-patch-1/dcl-sdk-commands-7.1.18-5137100703.commit-39b7113.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/menduz-patch-1/@dcl/inspector/dcl-inspector-7.1.18-5137100703.commit-39b7113.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/menduz-patch-1-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=menduz-patch-1

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (3bb30f9) 72.49% compared to head (31a5ad0) 72.49%.

❗ Current head 31a5ad0 differs from pull request most recent head 81b71e8. Consider uploading reports for the commit 81b71e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   72.49%   72.49%   -0.01%     
==========================================
  Files         267      267              
  Lines        8816     8815       -1     
  Branches     1141     1141              
==========================================
- Hits         6391     6390       -1     
  Misses       2308     2308              
  Partials      117      117              
Impacted Files Coverage Δ
...dcl/inspector/src/lib/sdk/operations/set-parent.ts 47.36% <50.00%> (-2.64%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicoecheza nicoecheza merged commit 80c8909 into main May 31, 2023
@nicoecheza nicoecheza deleted the menduz-patch-1 branch May 31, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants