Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent catalog error to make inspector fail to boot #613

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented May 29, 2023

Fixes decentraland/sdk#803

🤖 Generated by Copilot at a4123f3

Refactored the catalog data fetching and rendering logic in the inspector's assets component. Moved the useCatalog hook from Assets.tsx to AssetsCatalog.tsx and handled possible errors from the API. Removed unused props and CSS file.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5e9032
Status: ✅  Deploy successful!
Preview URL: https://3013e3d0.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-catalog-error.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/catalog-error/dcl-sdk-7.1.18-5147724632.commit-0f7784d.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/catalog-error/dcl-sdk-commands-7.1.18-5147724632.commit-0f7784d.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/catalog-error/@dcl/inspector/dcl-inspector-7.1.18-5147724632.commit-0f7784d.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/catalog-error-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/catalog-error

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.35 🎉

Comparison is base (80c8909) 72.49% compared to head (d5e9032) 72.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   72.49%   72.84%   +0.35%     
==========================================
  Files         267      267              
  Lines        8815     8816       +1     
  Branches     1141     1153      +12     
==========================================
+ Hits         6390     6422      +32     
+ Misses       2308     2277      -31     
  Partials      117      117              
Impacted Files Coverage Δ
...cl/inspector/src/components/AssetsCatalog/types.ts 0.00% <ø> (ø)
...ges/@dcl/inspector/src/hooks/catalog/useCatalog.ts 100.00% <100.00%> (+87.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cazala cazala force-pushed the fix/catalog-error branch from eda32ad to fc69ccc Compare May 30, 2023 18:02
@cazala cazala enabled auto-merge (squash) June 1, 2023 18:07
@cazala cazala merged commit 9d9918a into main Jun 1, 2023
@cazala cazala deleted the fix/catalog-error branch June 1, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector fails to load when Builder assets are unavailable
2 participants