Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signed-fetch headers rpc #611

Merged
merged 3 commits into from
May 29, 2023
Merged

add signed-fetch headers rpc #611

merged 3 commits into from
May 29, 2023

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented May 26, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b2e833
Status: ✅  Deploy successful!
Preview URL: https://db158fde.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-signed-fetch-headers.js-sdk-toolchain.pages.dev

View logs

@gonpombo8 gonpombo8 force-pushed the feat/signed-fetch-headers branch from 7141424 to 2054c82 Compare May 26, 2023 16:14
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ac35286) 72.48% compared to head (3b2e833) 72.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   72.48%   72.48%           
=======================================
  Files         267      267           
  Lines        8772     8772           
  Branches     1134     1134           
=======================================
  Hits         6358     6358           
  Misses       2297     2297           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/signed-fetch-headers/dcl-sdk-7.1.17-5112364618.commit-7f69bbc.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/signed-fetch-headers/dcl-sdk-commands-7.1.17-5112364618.commit-7f69bbc.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/signed-fetch-headers/@dcl/inspector/dcl-inspector-7.1.17-5112364618.commit-7f69bbc.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/signed-fetch-headers-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/signed-fetch-headers

Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gonpombo8 gonpombo8 merged commit eb35f6f into main May 29, 2023
@gonpombo8 gonpombo8 deleted the feat/signed-fetch-headers branch May 29, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants