Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat asset folder UI #602

Merged
merged 3 commits into from
May 25, 2023
Merged

Feat asset folder UI #602

merged 3 commits into from
May 25, 2023

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented May 24, 2023

image

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e09b1f8
Status: ✅  Deploy successful!
Preview URL: https://9380cb70.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-asset-folder-ui.js-sdk-toolchain.pages.dev

View logs

@gonpombo8 gonpombo8 force-pushed the feat/asset-folder-ui branch from 6e5b8c2 to e09b1f8 Compare May 24, 2023 20:16
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/asset-folder-ui/dcl-sdk-7.1.17-5073040824.commit-6d6ffbc.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/asset-folder-ui/dcl-sdk-commands-7.1.17-5073040824.commit-6d6ffbc.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/asset-folder-ui/@dcl/inspector/dcl-inspector-7.1.17-5073040824.commit-6d6ffbc.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/asset-folder-ui-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/asset-folder-ui

Copy link
Member

@cazala cazala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful 💅

@gonpombo8 gonpombo8 merged commit e2edf25 into main May 25, 2023
@gonpombo8 gonpombo8 deleted the feat/asset-folder-ui branch May 25, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants