Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gizmos settings #596

Merged
merged 4 commits into from
May 23, 2023
Merged

fix: gizmos settings #596

merged 4 commits into from
May 23, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented May 22, 2023

Closes decentraland/sdk#791
Closes decentraland/sdk#775

🤖 Generated by Copilot at 259bb89

This pull request enhances the inspector tool for the Decentraland SDK by fixing some issues with the gizmo manager and the snap panel. It also improves the testing and code style of the relevant files.

@cazala cazala requested a review from nicoecheza May 22, 2023 20:50
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a682b77
Status: ✅  Deploy successful!
Preview URL: https://ee2a925d.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-gizmos-settings.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/gizmos-settings/dcl-sdk-7.1.16-5057581038.commit-91d812c.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/gizmos-settings/dcl-sdk-commands-7.1.16-5057581038.commit-91d812c.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/gizmos-settings/@dcl/inspector/dcl-inspector-7.1.16-5057581038.commit-91d812c.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/gizmos-settings-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/gizmos-settings

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (e7ba7f7) 72.01% compared to head (a682b77) 72.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   72.01%   72.02%   +0.01%     
==========================================
  Files         254      254              
  Lines        8643     8648       +5     
  Branches     1112     1113       +1     
==========================================
+ Hits         6224     6229       +5     
  Misses       2310     2310              
  Partials      109      109              
Impacted Files Coverage Δ
...cl/inspector/src/hooks/editor/useGizmoAlignment.ts 100.00% <100.00%> (ø)
...ctor/src/lib/babylon/decentraland/gizmo-manager.ts 94.88% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cazala cazala enabled auto-merge (squash) May 23, 2023 12:59
@cazala cazala merged commit c718b1c into main May 23, 2023
@cazala cazala deleted the fix/gizmos-settings branch May 23, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants