Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panel should not be always open #580

Merged
merged 1 commit into from
May 12, 2023
Merged

fix: panel should not be always open #580

merged 1 commit into from
May 12, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented May 12, 2023

This slipped through in my last PR 🙏

@cazala cazala enabled auto-merge (squash) May 12, 2023 13:25
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d4cfd30
Status: ✅  Deploy successful!
Preview URL: https://97bb024d.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-panel-always-open.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/panel-always-open/dcl-sdk-7.1.12-4959372567.commit-fe03ce4.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/panel-always-open/dcl-sdk-commands-7.1.12-4959372567.commit-fe03ce4.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/panel-always-open/@dcl/inspector/dcl-inspector-7.1.12-4959372567.commit-fe03ce4.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/panel-always-open-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/panel-always-open

@cazala cazala merged commit 47fda0f into main May 12, 2023
@cazala cazala deleted the fix/panel-always-open branch May 12, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants