Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renderer resizing #577

Merged
merged 2 commits into from
May 11, 2023
Merged

fix: renderer resizing #577

merged 2 commits into from
May 11, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented May 10, 2023

closes decentraland/sdk#762

May-10-2023 15-43-08

🤖 Generated by Copilot at 1941e40

We are the inspectors of doom
We wield the power of the .Resizable class
We slice the panel with the .resize-handle
We refactor and simplify, we are the masters of CSS

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f4128f3
Status: ✅  Deploy successful!
Preview URL: https://0c5fc36e.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-window-resizing.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/window-resizing/dcl-sdk-7.1.12-4952523450.commit-92ebd55.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/window-resizing/dcl-sdk-commands-7.1.12-4952523450.commit-92ebd55.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/window-resizing/@dcl/inspector/dcl-inspector-7.1.12-4952523450.commit-92ebd55.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/window-resizing-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/window-resizing

@nicoecheza nicoecheza enabled auto-merge (squash) May 10, 2023 22:43
@cazala
Copy link
Member

cazala commented May 11, 2023

is it intended that resizing the window resizes the sidebar too?

@nicoecheza
Copy link
Contributor Author

is it intended that resizing the window resizes the sidebar too?

mmmm good catch. I will add the min width/height prop as a style to the first children on the Resizable component so we always maintain those constrains 👍

@nicoecheza nicoecheza force-pushed the fix/window-resizing branch from f580c5a to 7105792 Compare May 11, 2023 19:03
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.30 ⚠️

Comparison is base (65d68ce) 71.33% compared to head (7105792) 71.04%.

❗ Current head 7105792 differs from pull request most recent head f4128f3. Consider uploading reports for the commit f4128f3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   71.33%   71.04%   -0.30%     
==========================================
  Files         248      247       -1     
  Lines        8433     8267     -166     
  Branches     1061     1079      +18     
==========================================
- Hits         6016     5873     -143     
+ Misses       2312     2294      -18     
+ Partials      105      100       -5     

see 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicoecheza nicoecheza force-pushed the fix/window-resizing branch from 7105792 to f4128f3 Compare May 11, 2023 21:02
@nicoecheza nicoecheza merged commit f1e3981 into main May 11, 2023
@nicoecheza nicoecheza deleted the fix/window-resizing branch May 11, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector window should resize correctly
2 participants