Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nft shape urn update #575

Merged
merged 11 commits into from
May 15, 2023
Merged

chore: nft shape urn update #575

merged 11 commits into from
May 15, 2023

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented May 10, 2023

  • Updated protocol package with nftshape property name change

issue: decentraland/sdk#745

other related PRs:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2086506
Status: ✅  Deploy successful!
Preview URL: https://a67ecc47.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-nft-shape-urn-update.js-sdk-toolchain.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b87aa7) 71.83% compared to head (9fcac32) 71.83%.

❗ Current head 9fcac32 differs from pull request most recent head 2086506. Consider uploading reports for the commit 2086506 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         251      251           
  Lines        8449     8449           
  Branches     1083     1083           
=======================================
  Hits         6069     6069           
  Misses       2272     2272           
  Partials      108      108           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pravusjif
Copy link
Member Author

Will change protocol package to point to the new published one after decentraland/protocol#146 is merged and published

@pravusjif pravusjif marked this pull request as ready for review May 10, 2023 13:20
@pravusjif pravusjif marked this pull request as draft May 10, 2023 14:10
@pravusjif
Copy link
Member Author

pravusjif commented May 10, 2023

Wearables should be supported now so the implementation will take longer, going back to draft

@pravusjif
Copy link
Member Author

pravusjif commented May 11, 2023

  • Supporting decentraland wearable/emote NFTs with raw urns will be tackled in another issue post-beta phase
  • Tried to implement matic nfts fetching support but Opensea API doesn't support fetching nft info from non-ethereum chains yet

@pravusjif pravusjif marked this pull request as ready for review May 11, 2023 19:17
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/nft-shape-urn-update/dcl-sdk-7.1.12-4982735914.commit-b3728ba.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/nft-shape-urn-update/dcl-sdk-commands-7.1.12-4982735914.commit-b3728ba.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/nft-shape-urn-update/@dcl/inspector/dcl-inspector-7.1.12-4982735914.commit-b3728ba.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/nft-shape-urn-update-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/nft-shape-urn-update

@pravusjif pravusjif merged commit f2f84bd into main May 15, 2023
@pravusjif pravusjif deleted the chore/nft-shape-urn-update branch May 15, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants