Remove self-contained GLTF/GLB asset #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoecheza
force-pushed
the
feat/asset-removal
branch
from
ddee27e to
021da35
Compare
Deploying with
|
| Latest commit: |
a7b467a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6f4fdf3.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-asset-removal.js-sdk-toolchain.pages.dev |
nicoecheza
force-pushed
the
feat/asset-removal
branch
from
021da35 to
0ebe674
Compare
Test this pull request
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
- Coverage 71.88% 71.60% -0.29%
==========================================
Files 245 247 +2
Lines 8416 8451 +35
Branches 1073 1075 +2
==========================================
+ Hits 6050 6051 +1
- Misses 2268 2300 +32
- Partials 98 100 +2
☔ View full report in Codecov by Sentry. |
nicoecheza
force-pushed
the
feat/asset-removal
branch
3 times, most recently
from
5b7584c to
de9b436
Compare
nicoecheza
force-pushed
the
feat/asset-removal
branch
3 times, most recently
from
970a1fe to
9e1f5ad
Compare
cazala
reviewed
May 9, 2023
nicoecheza
force-pushed
the
feat/asset-removal
branch
from
9e1f5ad to
36d0e6b
Compare
cazala
approved these changes
May 10, 2023
cazala
approved these changes
May 10, 2023
cazala
approved these changes
May 10, 2023
nicoecheza
force-pushed
the
feat/asset-removal
branch
2 times, most recently
from
ca99ea3 to
963cb8a
Compare
nicoecheza
force-pushed
the
feat/asset-removal
branch
from
963cb8a to
a7b467a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes decentraland/sdk#757
🤖 Generated by Copilot at ddee27e
This pull request adds and updates several components and files in the
@dcl/inspectorpackage, mainly to improve the UI and functionality of the inspector tool. It introduces thereact-modalandclassnamesmodules as dependencies, and uses them to create aModalcomponent and to apply conditional styles to theButtonandBlockcomponents. It also adds the ability to remove an asset from the project, and shows a warning modal if the asset is used by some components. It simplifies some code by using hooks and variables, and fixes some minor issues with the input validation and the context menu.