Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: editor sidebar to allow vertical resizement #544

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Apr 26, 2023

closes decentraland/sdk#722

🤖 Generated by Copilot at f3b0bac

This pull request enhances the inspector tool by adding a resizeable hierarchy panel, a memoized tab switching function, and vertical scrolling for the inspector panel. It also fixes a CSS syntax error, disables text selection, and refactors some code for readability and performance. The changes affect the App, Resizable, Container, Hierarchy, and Tree components and their corresponding CSS and types files.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0dff62a
Status: ✅  Deploy successful!
Preview URL: https://ff12cdf6.js-sdk-toolchain.pages.dev
Branch Preview URL: https://update-resizable.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/update/resizable/dcl-sdk-7.1.10-4812592126.commit-8a7671e.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/update/resizable/dcl-sdk-commands-7.1.10-4812592126.commit-8a7671e.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/update/resizable/@dcl/inspector/dcl-inspector-7.1.10-4812592126.commit-8a7671e.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/update/resizable-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=update/resizable

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.26 ⚠️

Comparison is base (8752a16) 69.58% compared to head (0dff62a) 69.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   69.58%   69.32%   -0.26%     
==========================================
  Files         224      224              
  Lines        7822     7851      +29     
  Branches      962      962              
==========================================
  Hits         5443     5443              
- Misses       2283     2312      +29     
  Partials       96       96              
Impacted Files Coverage Δ
...s/@dcl/inspector/src/components/Resizable/types.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

}
}

export const HORIZONTAL_PROPS: TypeProps = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not types 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but they're not important enough to live in their own file and I don't want them in the actual component either, so until this component grows bigger, I think this file is the best for now

@nicoecheza nicoecheza merged commit e5fbd2f into main Apr 26, 2023
@nicoecheza nicoecheza deleted the update/resizable branch April 26, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite inspector & entity inspector layout
2 participants