feat: snap #543
feat: snap #543
Conversation
Deploying with
|
| Latest commit: |
e593572
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76da4f19.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-snap.js-sdk-toolchain.pages.dev |
Test this pull request
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
+ Coverage 69.16% 69.58% +0.41%
==========================================
Files 229 235 +6
Lines 7870 8097 +227
Branches 967 1021 +54
==========================================
+ Hits 5443 5634 +191
- Misses 2326 2358 +32
- Partials 101 105 +4
☔ View full report in Codecov by Sentry. |
cazala
force-pushed
the
feat/snap
branch
3 times, most recently
from
f341815 to
03a8698
Compare
| @@ -25,7 +25,7 @@ module.exports = { | |||
| collectCoverageFrom: ["src/**/*.ts"], | |||
| verbose: true, | |||
| testMatch: ["**/*.spec.(ts)"], | |||
| testEnvironment: "node", | |||
| testEnvironment: "jsdom", | |||
There was a problem hiding this comment.
should this svg be react components 🤔 ?
Just to be consistent with the app, no idea just thinking out loud
There was a problem hiding this comment.
Sure, we can do that but it would require to configure a loader for svgs so que can import Icon from "./path/to/icon.svg" and then use it as <Icon />. I would rather do that as a separate PR.
| @@ -0,0 +1,21 @@ | |||
| import { useEffect, useRef } from 'react' | |||
|
|
|||
| export const useOutsideClick = (callback: () => void) => { | |||
Closes decentraland/sdk#706
snapManagerto control snap distance for position/scale/rotation and enable/disableshiftto toggle snappingsnap.mp4
Hint: hold
shiftto toggle the snapping