update @dcl/protocol@next #540
Conversation
Deploying with
|
| Latest commit: |
f4712d8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://937cc75b.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://update-protocol-6v6p.js-sdk-toolchain.pages.dev |
Test this pull request
|
| @@ -82,7 +82,7 @@ export async function bundleProject(components: BundleComponents, options: Compi | |||
| metafile: true, | |||
| absWorkingDir: options.workingDirectory, | |||
| target: 'es2020', | |||
| external: ['~system/*'], | |||
| external: ['~system/*', '@dcl/inspector' /* ban importing the inspector from the SDK */], | |||
Signed-off-by: menduz <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
=======================================
Coverage 69.58% 69.58%
=======================================
Files 224 224
Lines 7822 7822
Branches 962 962
=======================================
Hits 5443 5443
Misses 2283 2283
Partials 96 96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -82,7 +82,7 @@ export async function bundleProject(components: BundleComponents, options: Compi | |||
| metafile: true, | |||
| absWorkingDir: options.workingDirectory, | |||
| target: 'es2020', | |||
| external: ['~system/*'], | |||
| external: ['~system/*', '@dcl/inspector', '@dcl/inspector/*' /* ban importing the inspector from the SDK */], | |||
There was a problem hiding this comment.
if it's marked as external, the build won't fail, but it'll fail at runtime
There was a problem hiding this comment.
At least it will fail this way. isn't that better than allowing it and embedding babylon?
I didn't figure other solution so far, ideas?
No description provided.