Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add UiCanvasInformation component #533

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Conversation

menduz
Copy link
Member

@menduz menduz commented Apr 19, 2023

And update @dcl/protocol package

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f1f755
Status: ✅  Deploy successful!
Preview URL: https://34fc8643.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-ui-canvas-information.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add-ui-canvas-information/dcl-sdk-7.1.8-4748238283.commit-6d0e618.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add-ui-canvas-information/dcl-sdk-commands-7.1.8-4748238283.commit-6d0e618.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add-ui-canvas-information/@dcl/inspector/dcl-inspector-7.1.8-4748238283.commit-6d0e618.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add-ui-canvas-information-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add-ui-canvas-information

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (377c8b9) 66.42% compared to head (1f1f755) 66.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files         219      219           
  Lines        7670     7670           
  Branches      933      933           
=======================================
  Hits         5095     5095           
  Misses       2476     2476           
  Partials       99       99           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@menduz menduz force-pushed the add-ui-canvas-information branch from e60acd4 to f2720ce Compare April 19, 2023 21:40
@menduz menduz enabled auto-merge (squash) April 19, 2023 22:41
@menduz menduz requested review from nicoecheza and pbosio April 19, 2023 22:42
@menduz menduz merged commit c71195f into main Apr 20, 2023
@menduz menduz deleted the add-ui-canvas-information branch April 20, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants