Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dropping folders on Gltf UI component #531

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Apr 19, 2023

closes decentraland/sdk#725

If the user drops a folder that has only one child across the whole chain of childrens, and that child is an asset, we will use it to create the Gltf component

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 41ee15f
Status: ✅  Deploy successful!
Preview URL: https://e0fb4ac8.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-support-gltf-folder-dro.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/support-gltf-folder-drop/dcl-sdk-7.1.8-4747105307.commit-22917bd.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/support-gltf-folder-drop/dcl-sdk-commands-7.1.8-4747105307.commit-22917bd.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/support-gltf-folder-drop/@dcl/inspector/dcl-inspector-7.1.8-4747105307.commit-22917bd.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/support-gltf-folder-drop-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/support-gltf-folder-drop

@nicoecheza nicoecheza force-pushed the feat/support-gltf-folder-drop branch 3 times, most recently from eb8cdcb to 522b1f3 Compare April 19, 2023 16:38
@nicoecheza nicoecheza marked this pull request as ready for review April 19, 2023 16:38
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.05 ⚠️

Comparison is base (00dea08) 66.21% compared to head (eaaf847) 66.16%.

❗ Current head eaaf847 differs from pull request most recent head 41ee15f. Consider uploading reports for the commit 41ee15f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   66.21%   66.16%   -0.05%     
==========================================
  Files         219      219              
  Lines        7665     7670       +5     
  Branches      930      930              
==========================================
  Hits         5075     5075              
- Misses       2490     2495       +5     
  Partials      100      100              
Impacted Files Coverage Δ
...ector/src/components/ProjectAssetExplorer/utils.ts 0.00% <0.00%> (ø)
packages/@dcl/inspector/src/lib/logic/once.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicoecheza nicoecheza force-pushed the feat/support-gltf-folder-drop branch from 522b1f3 to eaaf847 Compare April 19, 2023 18:33
@nicoecheza nicoecheza force-pushed the feat/support-gltf-folder-drop branch from eaaf847 to e5d43b7 Compare April 19, 2023 19:15
@nicoecheza nicoecheza force-pushed the feat/support-gltf-folder-drop branch from e5d43b7 to 41ee15f Compare April 19, 2023 19:20
@nicoecheza nicoecheza enabled auto-merge (squash) April 19, 2023 19:23
@nicoecheza nicoecheza merged commit 377c8b9 into main Apr 19, 2023
@nicoecheza nicoecheza deleted the feat/support-gltf-folder-drop branch April 19, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dropping folders in Gltf UI component
2 participants