refactor: composite #1042
Merged
refactor: composite #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
==========================================
- Coverage 64.03% 63.58% -0.46%
==========================================
Files 579 580 +1
Lines 18049 18314 +265
Branches 2288 2301 +13
==========================================
+ Hits 11558 11645 +87
- Misses 6082 6259 +177
- Partials 409 410 +1 ☔ View full report in Codecov by Sentry. |
Deploying js-sdk-toolchain with
|
| Latest commit: |
924ca78
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca8f6168.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://refactor-composite.js-sdk-toolchain.pages.dev |
Test this pull request
|
cyaiox
reviewed
Dec 2, 2024
|
|
||
| export enum DropTypesEnum { | ||
| ProjectAsset = 'project-asset', | ||
| BuilderAsset = 'builder-asset' | ||
| ProjectAsset = 'local-asset', |
There was a problem hiding this comment.
should be here?
Suggested change
| ProjectAsset = 'local-asset', | |
| LocalAsset = 'local-asset', |
cyaiox
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the
addAssetoperation to work with the new@dcl/asset-packsasset format, which uses composites instead of the custom format.It also adds support for multiple entities per item, since the composite supports multiple entities. When multiple entities are present, a main entity will be created (this one will have the Transform in the position the user selected) and the item's entities will be added as children of that main entity. When a single entity is used and it's id is 0, then those components will be added to the main entities (to avoid having the main entity with a single child when only 1 entity is needed. which is the case of the current smart items).
Finally, it refactors the ProjectAssets and BuilderAssets into LocalAssets and CatalogAssets, which match better the current nomenclatures.