Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multipalyer clone issue at runtime #1039

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

gonpombo8
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56011da
Status: ✅  Deploy successful!
Preview URL: https://8f4be939.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-multiplayer-clone.js-sdk-toolchain.pages.dev

View logs

@gonpombo8 gonpombo8 force-pushed the fix/multiplayer-clone branch from 32040ca to 9caa3b9 Compare November 25, 2024 14:26
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/multiplayer-clone/dcl-sdk-7.6.7-12147943562.commit-9411455.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/multiplayer-clone/dcl-sdk-commands-7.6.7-12147943562.commit-9411455.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/multiplayer-clone/@dcl/inspector/dcl-inspector-7.6.7-12147943562.commit-9411455.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/multiplayer-clone-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/multiplayer-clone

@@ -2,7 +2,7 @@
"name": "@dcl/inspector",
"version": "0.1.0",
"dependencies": {
"@dcl/asset-packs": "1.20.2",
"@dcl/asset-packs": "^1.20.3-20241003132817.commit-926ddc8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update asset-packs to latest

@gonpombo8 gonpombo8 force-pushed the fix/multiplayer-clone branch from d50fc5f to 1c00aef Compare December 3, 2024 17:51
@gonpombo8 gonpombo8 force-pushed the fix/multiplayer-clone branch from a3ddd6b to 56011da Compare December 3, 2024 20:54
@gonpombo8 gonpombo8 enabled auto-merge (squash) December 3, 2024 20:57
@gonpombo8 gonpombo8 merged commit 085da37 into main Dec 3, 2024
8 checks passed
@gonpombo8 gonpombo8 deleted the fix/multiplayer-clone branch December 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants