Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: put snapshots comparison back #1033

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Nov 11, 2024

I'm aware these snapshots are a mess to review in each PR, but having it is better than merging blindly

It also updates the snapshots as it's been a while since the last update.

Copy link

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74fcd9e
Status: ✅  Deploy successful!
Preview URL: https://0502f7e3.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-put-snapshots-comparis.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/put-snapshots-comparison-back/dcl-sdk-7.6.5-11778892926.commit-d105304.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/put-snapshots-comparison-back/dcl-sdk-commands-7.6.5-11778892926.commit-d105304.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/put-snapshots-comparison-back/@dcl/inspector/dcl-inspector-7.6.5-11778892926.commit-d105304.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/put-snapshots-comparison-back-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/put-snapshots-comparison-back

@leanmendoza leanmendoza merged commit 9328e04 into main Nov 11, 2024
8 checks passed
@leanmendoza leanmendoza deleted the chore/put-snapshots-comparison-back branch November 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants