Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panels size #1017

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: Panels size #1017

merged 3 commits into from
Oct 10, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Oct 9, 2024

This PR fixes the min size assets panel size.

Screen.Recording.2024-10-10.at.11.56.19.AM.mov

Copy link

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39953ab
Status: ✅  Deploy successful!
Preview URL: https://07abcddf.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-panels-size.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/panels-size/dcl-sdk-7.6.2-11264406798.commit-d9b83d9.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/panels-size/dcl-sdk-commands-7.6.2-11264406798.commit-d9b83d9.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/panels-size/@dcl/inspector/dcl-inspector-7.6.2-11264406798.commit-d9b83d9.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/panels-size-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/panels-size

@cyaiox cyaiox marked this pull request as ready for review October 9, 2024 23:14
@cyaiox cyaiox merged commit 0c4dc9b into main Oct 10, 2024
8 checks passed
@cyaiox cyaiox deleted the fix/panels-size branch October 10, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants