Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add entity Name editing from EntityInspector #1012

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

nicoecheza
Copy link
Contributor

Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c83afb
Status: ✅  Deploy successful!
Preview URL: https://bd2847c7.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-entity-name-editing.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/entity-name-editing/dcl-sdk-7.6.1-11044436116.commit-cde2fdd.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/entity-name-editing/dcl-sdk-commands-7.6.1-11044436116.commit-cde2fdd.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/entity-name-editing/@dcl/inspector/dcl-inspector-7.6.1-11044436116.commit-cde2fdd.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/entity-name-editing-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/entity-name-editing

@nicoecheza nicoecheza force-pushed the add/entity-name-editing branch 2 times, most recently from ae7504d to 3bab9a1 Compare September 26, 2024 02:24
@nicoecheza nicoecheza force-pushed the add/entity-name-editing branch from 3bab9a1 to 8c83afb Compare September 26, 2024 02:25
@nicoecheza nicoecheza enabled auto-merge (squash) September 26, 2024 02:26
@nicoecheza nicoecheza merged commit ed941d5 into main Sep 26, 2024
8 checks passed
@nicoecheza nicoecheza deleted the add/entity-name-editing branch September 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rename option on Item Properties tab
2 participants