chore: virtual camera components iteration (#998)

Updated protocol and adapted to it.
decentraland · Sep 17, 2024 · 3fc6621 · 3fc6621
1 parent ddc542d
commit 3fc6621
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 34 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
   "bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
   "dependencies": {
     "@actions/core": "^1.10.0",
-    "@dcl/protocol": "1.0.0-10704143848.commit-a0c6d86",
+    "@dcl/protocol": "1.0.0-10884114018.commit-31410eb",
     "@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1",
     "@dcl/ts-proto": "1.153.0",
     "@types/fs-extra": "^9.0.12",

diff --git a/packages/@dcl/playground-assets/etc/playground-assets.api.md b/packages/@dcl/playground-assets/etc/playground-assets.api.md
@@ -355,10 +355,6 @@ export const CameraModeArea: LastWriteWinElementSetComponentDefinition<PBCameraM
 
 // @public (undocumented)
 export interface CameraTransition {
-    // (undocumented)
-    fromEntity?: number | undefined;
-    // (undocumented)
-    toEntity?: number | undefined;
     // (undocumented)
     transitionMode?: {
         $case: "time";
@@ -2387,7 +2383,7 @@ export namespace PBInputModifier_StandardInput {
 
 // @public (undocumented)
 export interface PBMainCamera {
-    virtualCameraEntity: number;
+    virtualCameraEntity?: number | undefined;
 }
 
 // @public (undocumented)
@@ -3216,7 +3212,7 @@ export namespace PBVideoPlayer {
 // @public (undocumented)
 export interface PBVirtualCamera {
     // (undocumented)
-    defaultTransition: CameraTransition | undefined;
+    defaultTransition?: CameraTransition | undefined;
     // (undocumented)
     lookAtEntity?: number | undefined;
 }

diff --git a/packages/@dcl/sdk-commands/package-lock.json b/packages/@dcl/sdk-commands/package-lock.json
diff --git a/packages/@dcl/sdk-commands/package.json b/packages/@dcl/sdk-commands/package.json
@@ -13,7 +13,7 @@
     "@dcl/inspector": "file:../inspector",
     "@dcl/linker-dapp": "^0.14.2",
     "@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be",
-    "@dcl/protocol": "1.0.0-10704143848.commit-a0c6d86",
+    "@dcl/protocol": "1.0.0-10884114018.commit-31410eb",
     "@dcl/quests-client": "^1.0.3",
     "@dcl/quests-manager": "^0.1.4",
     "@dcl/rpc": "^1.1.1",

diff --git a/test/ecs/components/VirtualCamera.spec.ts b/test/ecs/components/VirtualCamera.spec.ts
@@ -9,9 +9,7 @@ describe('VirtualCamera component', () => {
         transitionMode: {
           $case: 'time',
           time: 3
-        },
-        fromEntity: 6,
-        toEntity: 66
+        }
       },
       lookAtEntity: 35
     })
@@ -22,9 +20,7 @@ describe('VirtualCamera component', () => {
     const vCamera = components.VirtualCamera(newEngine)
     testComponentSerialization(vCamera, {
       defaultTransition: {
-        transitionMode: vCamera.Transition.Time(6),
-        fromEntity: 9,
-        toEntity: 99
+        transitionMode: vCamera.Transition.Time(6)
       },
       lookAtEntity: 86
     })
@@ -37,9 +33,7 @@ describe('VirtualCamera component', () => {
         transitionMode: {
           $case: 'speed',
           speed: 13
-        },
-        fromEntity: 9,
-        toEntity: 99
+        }
       },
       lookAtEntity: 86
     })
@@ -50,9 +44,7 @@ describe('VirtualCamera component', () => {
     const vCamera = components.VirtualCamera(newEngine)
     testComponentSerialization(vCamera, {
       defaultTransition: {
-        transitionMode: vCamera.Transition.Speed(15),
-        fromEntity: 9,
-        toEntity: 99
+        transitionMode: vCamera.Transition.Speed(15)
       },
       lookAtEntity: 86
     })