This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
feat: clipboard access #1300
Merged
feat: clipboard access #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pbosio
commented
Sep 14, 2020
pbosio
commented
- enable access to store text in the clipboard
- read text from the clipboard (firefox not supported)
- fix copy & paste in webgl build
|
This branch can be previewed at https://explorer.decentraland.zone/branch/feat/clipboard-access/index.html |
...cripts/MainScripts/DCL/Controllers/Clipboard/Implementation/Web/Plugins/ClipboardWebGL.jslib
Outdated
Show resolved
Hide resolved
unity-client/Assets/Scripts/MainScripts/DCL/Controllers/Scene/SceneController.cs
Outdated
Show resolved
Hide resolved
...nt/Assets/Scripts/MainScripts/DCL/Controllers/Clipboard/Implementation/Web/ClipboardWebGL.cs
Outdated
Show resolved
Hide resolved
...nt/Assets/Scripts/MainScripts/DCL/Controllers/Clipboard/Implementation/Web/ClipboardWebGL.cs
Outdated
Show resolved
Hide resolved
unity-client/Assets/Scripts/MainScripts/DCL/Controllers/Clipboard/ClipboardReadPromise.cs
Outdated
Show resolved
Hide resolved
...ets/Scripts/MainScripts/DCL/Controllers/Clipboard/Implementation/IClipboardImplementation.cs
Outdated
Show resolved
Hide resolved
unity-client/Assets/Scripts/MainScripts/DCL/Controllers/Clipboard/Clipboard.cs
Outdated
Show resolved
Hide resolved
unity-client/Assets/Scripts/MainScripts/DCL/Controllers/Clipboard/Clipboard.cs
Outdated
Show resolved
Hide resolved
pbosio
added
has addressable feedback
pbosio
added
ready for review
and removed
has addressable feedback
BrianAmadori
approved these changes
Sep 23, 2020
Comment on lines
7
to
19
| public class ClipboardTests : TestsBase | ||
| { | ||
| [UnitySetUp] | ||
| protected override IEnumerator SetUp() | ||
| { | ||
| yield break; | ||
| } | ||
|
|
||
| [UnityTearDown] | ||
| protected override IEnumerator TearDown() | ||
| { | ||
| yield break; | ||
| } |
There was a problem hiding this comment.
I think we can safely remove the TestsBase inheritance here, and thus don't need the SetUp and TearDown methods.
| @@ -22,6 +23,7 @@ private Environment() | |||
| messagingControllersManager = new MessagingControllersManager(); | |||
| pointerEventsController = new PointerEventsController(); | |||
| memoryManager = new MemoryManager(); | |||
| clipboard = Clipboard.Create(); | |||
|
|
||
| namespace DCL.Helpers | ||
| { | ||
| public class Promise<T> : CustomYieldInstruction |
Comment on lines
61
to
63
| public Promise() | ||
| { | ||
| } |
There was a problem hiding this comment.
Suggested change
| public Promise() | |
| { | |
| } |
sandrade-dcl
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Code reviewed! Only a thing: I have tested this build activating the new ProfileHUD (using ENABLE_NEW_TASKBAR url param) but I notice that the copy/paste behaviour is still not working with the wallet address... is it normal? do you have to apply some integration in the ProfileHUD after commit this PR to make it works?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.