feat: sanitize abi #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachomazzara
requested review from
nicosantangelo and
menduz
and removed request for
nicosantangelo
src/contracts/LANDRegistry.ts
Outdated
| fulfillContractMethods(this, abi) | ||
| const sanitizedABI = Abi.sanitize(abi) | ||
| super(address, sanitizedABI) | ||
| fulfillContractMethods(this, sanitizedABI) |
There was a problem hiding this comment.
The code looks 🆗 but shouldn't we do this for every contract (on Contract maybe)? or is it more of a specific case kind of thing?
There was a problem hiding this comment.
I think that we should sanitize ABIs when we need it.
I mean, if we don't have this issue with other contracts, we shouldn't sanitize them
nachomazzara
force-pushed
the
feat/sanitize-abi
branch
from
7d603b2
to
c64331a
Compare
nicosantangelo
approved these changes
Mar 7, 2019
|
🎉 This PR is included in version 8.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nicosantangelo
pushed a commit
to decentraland/marketplace-legacy
that referenced
this pull request
Mar 21, 2019
New version of decentraland-eth needed Depends on decentraland/decentraland-eth#56 and decentraland/decentraland-eth#57 Close #858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize ABI events with parameters name which conflict with web3 0.X.X