Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect with Decentraland IPFS node #75

Merged
merged 8 commits into from
Mar 6, 2018
Merged

Connect with Decentraland IPFS node #75

merged 8 commits into from
Mar 6, 2018

Conversation

nachomazzara
Copy link
Contributor

Resolve #66

menduz
menduz reviewed Mar 1, 2018
View reviewed changes
pages/linker.js
@@ -129,8 +156,8 @@ export default class Page extends React.Component {
try {
console.log('update land data', coordinates, data)
const tx = await land.updateManyLandData(coordinates, data)
this.setState({ tx })
closeServer(true, 'transaction successful')
this.watchTransactions(tx, coordinates[0].x, coordinates[0].y)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this watch the transaction for the whole Estate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait until transaction is completed by success or fail

pages/linker.js Outdated
const {peerId} = this.state
const tx = await txUtils.waitForCompletion(txId)
if (!txUtils.isFailure(tx)) {
this.setState({transactionLoading: false, pinningLoading: true})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format code before push

pages/linker.js
)

renderPinningIPFSStatus = () => (
!this.state.error && this.state.tx && !this.state.transactionLoading ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if(..) {
  return
} else if(..) {
  return
}
return null

Is probably easier to read

@nachomazzara nachomazzara merged commit 681ad45 into master Mar 6, 2018
@belohlavek belohlavek deleted the connect-with-ipfs-node branch April 9, 2018 05:53
fmiras pushed a commit that referenced this pull request Nov 20, 2018
@dependabot @fmiras
chore(deps-dev): bump lint-staged from 7.3.0 to 8.0.5 (#282)
4a87629 
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 7.3.0 to 8.0.5.
<details>
<summary>Release notes</summary>

*Sourced from [lint-staged's releases](https://github.com/okonet/lint-staged/releases).*

> ## v8.0.5
> ## [8.0.5](http://git+https/github.com/okonet/lint-staged/compare/v8.0.4...v8.0.5) (2018-11-17)
> 
> 
> ### Bug Fixes
> 
> * Use listr-update-renderer from npm ([#542](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/542)) ([503110d](http://git+https/github.com/okonet/lint-staged/commit/503110d)), closes [#533](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/533)
> 
> ## v8.0.4
> ## [8.0.4](http://git+https/github.com/okonet/lint-staged/compare/v8.0.3...v8.0.4) (2018-10-31)
> 
> 
> ### Bug Fixes
> 
> * **package:** update staged-git-files to version 1.1.2 ([ce434d3](http://git+https/github.com/okonet/lint-staged/commit/ce434d3))
> 
> ## v8.0.3
> ## [8.0.3](http://git+https/github.com/okonet/lint-staged/compare/v8.0.2...v8.0.3) (2018-10-30)
> 
> 
> ### Bug Fixes
> 
> * Allow to use lint-staged on CI ([#523](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/523)) ([225a904](http://git+https/github.com/okonet/lint-staged/commit/225a904))
> 
> ## v8.0.2
> ## [8.0.2](http://git+https/github.com/okonet/lint-staged/compare/v8.0.1...v8.0.2) (2018-10-29)
> 
> 
> ### Bug Fixes
> 
> * **git:** Use resolveGitDir in hasPartiallyStagedFiles ([#520](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/520)) ([af99172](http://git+https/github.com/okonet/lint-staged/commit/af99172)), closes [#514](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/514)
> 
> ## v8.0.1
> ## [8.0.1](http://git+https/github.com/okonet/lint-staged/compare/v8.0.0...v8.0.1) (2018-10-29)
> 
> 
> ### Bug Fixes
> 
> * **git:** Use resolveGitDir to resolve to .git for git commands ([#518](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/518)) ([da42f8a](http://git+https/github.com/okonet/lint-staged/commit/da42f8a)), closes [#514](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/514)
> 
> ## v8.0.0
> # [8.0.0](http://git+https/github.com/okonet/lint-staged/compare/v7.3.0...v8.0.0) (2018-10-29)
> 
> 
> ### Features
> 
> * Add support for partially staged files ([#75](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/75)) ([f82443c](http://git+https/github.com/okonet/lint-staged/commit/f82443c)), closes [#62](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/62)
> 
> 
> ### BREAKING CHANGES
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`503110d`](lint-staged/lint-staged@503110d) fix: Use listr-update-renderer from npm ([#542](https://github-redirect.dependabot.com/okonet/lint-staged/issues/542))
- [`6f6c08d`](lint-staged/lint-staged@6f6c08d) docs(readme): refine prettier examples ([#541](https://github-redirect.dependabot.com/okonet/lint-staged/issues/541))
- [`5e165a3`](lint-staged/lint-staged@5e165a3) Merge pull request [#513](https://github-redirect.dependabot.com/okonet/lint-staged/issues/513) from okonet/greenkeeper/staged-git-files-1.1.2
- [`07fd087`](lint-staged/lint-staged@07fd087) Merge branch 'master' into greenkeeper/staged-git-files-1.1.2
- [`00047de`](lint-staged/lint-staged@00047de) docs: fix typo ([#527](https://github-redirect.dependabot.com/okonet/lint-staged/issues/527))
- [`bedba5a`](lint-staged/lint-staged@bedba5a) refactor: Use object spread ([#524](https://github-redirect.dependabot.com/okonet/lint-staged/issues/524))
- [`225a904`](lint-staged/lint-staged@225a904) fix: Allow to use lint-staged on CI ([#523](https://github-redirect.dependabot.com/okonet/lint-staged/issues/523))
- [`af99172`](lint-staged/lint-staged@af99172) fix(git): Use resolveGitDir in hasPartiallyStagedFiles ([#520](https://github-redirect.dependabot.com/okonet/lint-staged/issues/520))
- [`da42f8a`](lint-staged/lint-staged@da42f8a) fix(git): Use resolveGitDir to resolve to .git for git commands ([#518](https://github-redirect.dependabot.com/okonet/lint-staged/issues/518))
- [`c4e8a2d`](lint-staged/lint-staged@c4e8a2d) chore(package): update lockfile yarn.lock
- Additional commits viewable in [compare view](lint-staged/lint-staged@v7.3.0...v8.0.5)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=7.3.0&new-version=8.0.5)](https://dependabot.com/compatibility-score.html?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=7.3.0&new-version=8.0.5)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@menduz menduz menduz left review comments

@cazala cazala cazala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nachomazzara @menduz @cazala