Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent test failure #17

Open
alyssais opened this issue Oct 29, 2018 · 1 comment
Open

Intermittent test failure #17

alyssais opened this issue Oct 29, 2018 · 1 comment

Comments

@alyssais
Copy link
Contributor

test_priority (tests.test_aioh2.TestServer) doesn't seem to be deterministic.

This causes a problem when packaging this library (eg NixOS/nixpkgs#49158), because the package build will randomly fail. For now, we can probably disable that test, but it should probably either be made more consistent, or, if that's not possible, not be run by default?
@fantix
Copy link
Member

fantix commented Oct 29, 2018

Thanks for the report and sorry for the trouble! I might have no spare time on this project right now. The almostEquals does look like unstable, I think we can skip this test first, and fix it a bit later.

alyssais added a commit to alyssais/aioh2 that referenced this issue Oct 29, 2018
@alyssais
Skip flakey priority test
1ba0131 
See decentfox#17.
@alyssais alyssais mentioned this issue Oct 29, 2018
Merged
alyssais added a commit to alyssais/nixpkgs that referenced this issue Oct 31, 2018
@alyssais
python3Packages.aioh2: init at 0.2.2
1f1bd5c 
Tests skipped due to decentfox/aioh2#17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fantix @alyssais