Show banner for when user delegated tokens after a proposal was made #2721
+365
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and removed false execution paths
Deploying decent-interface with
|
| Latest commit: |
1380cc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://141ffaa9.decent-interface.pages.dev |
| Branch Preview URL: | https://eng-91-voting-power-hint.decent-interface.pages.dev |
adamgall
reviewed
Feb 7, 2025
Comment on lines
63
to
75
| export const VOTE_CHOICES = [ | ||
| { | ||
| label: 'yes', | ||
| label: 'Approve', | ||
| value: 1, | ||
| }, | ||
| { | ||
| label: 'no', | ||
| label: 'Reject', | ||
| value: 0, | ||
| }, | ||
| { | ||
| label: 'abstain', | ||
| label: 'Abstain', | ||
| value: 2, | ||
| }, |
There was a problem hiding this comment.
Update from design:
There was a problem hiding this comment.
The lowercase "yes/no/abstain" are translation string keys though right?
There was a problem hiding this comment.
Oh... dang. Duh. Will update, thanks
Da-Colon
reviewed
Feb 10, 2025
| {showVotingPower ? proposalVotingWeight : t('show')} | ||
| </Button> | ||
| ); | ||
| const notEnoughVotingPowerAtTheTimeOfProposalCreation = |
There was a problem hiding this comment.
now if thats not an example of clear variable naming I don't know what is.
Da-Colon
reviewed
Feb 10, 2025
| @@ -73,7 +313,6 @@ export function AzoriusProposalSummary({ proposal }: { proposal: AzoriusProposal | |||
| address: tokenAddress, | |||
| client: publicClient, | |||
| }); | |||
| // @todo We should be checking proposal state - if it's active, we should use the latest block, otherwise we should calculate the voting weight based on the startBlock and deadlineMs | |||
There was a problem hiding this comment.
is this TODO no longer relavent?
There was a problem hiding this comment.
hm I don't remember. I'll take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue for testing instructions
I've also:
expandedViewI noticed the Quorum bar has been moved in the designs from the side panel to the Breakdown section:
I didn't do that here (too outta scope), but leaving it as is also led to ugly UI. For a middle ground I moved it out of the VoteSection, pending its move to the Votes Breakdown:
