Eng 61 update subgraph endpoints #2708

adamgall · 2025-02-03T20:56:30Z

Closes https://linear.app/decent-labs/issue/ENG-61/update-subgraph-endpoints
Closes https://linear.app/decent-labs/issue/ENG-97/remove-network-dependencies-from-build-process
Closes https://linear.app/decent-labs/issue/ENG-182/deployed-a-polygon-dao-does-not-load

linear · 2025-02-03T20:56:33Z

ENG-61 Update Subgraph endpoints

ENG-97 Remove network dependencies from build process

cloudflare-workers-and-pages · 2025-02-03T20:57:43Z

Deploying decent-interface with Cloudflare Pages

Latest commit:	`3b3066f`
Status:	✅ Deploy successful!
Preview URL:	https://517f6b5a.decent-interface.pages.dev
Branch Preview URL:	https://eng-61-update-subgraph-endpo.decent-interface.pages.dev

View logs

src/graphql/index.ts

src/components/DaoHierarchy/DaoHierarchyNode.tsx

- Moved GraphQL queries to separate files for better organization - Updated import paths for GraphQL queries - Implemented client caching in GraphQL client creation - Added new query files for Snapshot, Streams, and DAO queries - Removed deprecated snapshot client creation method

- Renamed GraphQL query constants from *QueryDocument to *Query - Updated import statements in various files to use new query names - Affected files include DaoHierarchyNode, DAOQueries, StreamsQueries, and several hooks

- Renamed `createDecentGraphClient` to `createDecentSubgraphClient` - Renamed `createSablierGraphClient` to `createSablierSubgraphClient` - Renamed `createSnapshotGraphClient` to `createSnapshotSubgraphClient` - Updated import statements across multiple files to use new function names

- Renamed `SubgraphConfig` to `TheGraphConfig` in types - Updated network configs to use `decentSubgraph` instead of `subgraph` - Modified GraphQL client creation to use the new configuration type

- Removed `version` field from TheGraphConfig type - Updated GraphQL client creation to use 'version/latest' for dev environments - Removed version configurations from all network config files

- Update `.env` and `vite-env.d.ts` to use `VITE_APP_THEGRAPH_API_KEY` - Modify GraphQL client creation to use the renamed environment variable - Consistent naming for TheGraph API key across the application

Da-Colon · 2025-02-04T22:16:41Z

package.json

-    "build:cf": "vite build && vite build --mode page-function",
-    "graphql:build": "graphclient build",
-    "graphql:dev-server": "graphclient serve-dev",
-    "test": "vitest --dir=test",
-    "postinstall": "npm run graphql:build"


Da-Colon · 2025-02-04T22:18:00Z

src/components/DaoHierarchy/DaoHierarchyNode.tsx

-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);


👀 sweet if we don't need this anymore. tested Myosin good stress tester for org page.

Da-Colon · 2025-02-04T22:26:26Z

src/graphql/index.ts

+  // Check if we already have a client for this URL
+  const cachedClient = clientCache.get(url);
+  if (cachedClient) {
+    return cachedClient;
+  }


Why do we cache the client? looking at the documentation, and is this instead of create a context provider?

Decided to implement this lil caching mechanism (thanks for the suggestion @mudrila), specifically because I've removed the context provider.

Wherever we need to utilize a graphql client, we create (or get from cache) an instance of it on the fly, instead of using the "one" that would be in a Provider context.

Decided to do it like this because of how diverse our graphql clients are. Effectively the "url" property of a urql client instance is the thing that makes it unique, and given that there are 3 dimension in which this "url" can differ (dev vs prod (2), decent vs sablier (2), all the networks (5)), there are 2 * 2 * 5 = 20 different potential endpoints for the urql client. Rather than just include one of those client instances in a Provider context, i said fuggit and we just create one (or pull from cache) as needed.

I didn't really do any profiling to see how expensive it is to create these different clients, but the caching layer here is so light it seemed like a simple thing to implement.

Da-Colon · 2025-02-04T22:28:15Z

src/hooks/DAO/loaders/useFractalGovernance.ts

@@ -146,14 +158,15 @@ export const useFractalGovernance = () => {
    type,
  ]);

+  const proposalsLoadKey = useRef<string>();


Da-Colon · 2025-02-04T22:32:28Z

src/store/roles/rolesStoreUtils.ts

@@ -346,7 +337,7 @@ const getPaymentStreams = async (
    });

    const streamsWithCurrentWithdrawableAmounts: SablierPayment[] = await Promise.all(
-      formattedLinearStreams.map(async stream => {
+      formattedLinearStreams.map(async (stream: any) => {


you mean to leave as type any?

Ah shit, good point. I'm realizing now that there's no typing for the result of these queries...

sigh, I'll need to get back into this.

oke pushed some more code

Da-Colon · 2025-02-04T22:32:43Z

src/store/roles/rolesStoreUtils.ts

    );
-    const formattedLinearStreams = lockupLinearStreams.map(lockupLinearStream => {
+    const formattedLinearStreams = lockupLinearStreams.map((lockupLinearStream: any) => {


you mean to leave as type any?

- Add type definitions for DAO, Snapshot, and Streams GraphQL queries - Enhance type safety in GraphQL query calls across multiple hooks and components - Improve error handling and data validation in GraphQL query processing - Remove unnecessary fields and simplify query response types

Da-Colon

Good deal. Send it

adamgall · 2025-02-05T15:38:13Z

Definitely need to some more manual testing on Snapshot integration. I think that's the code that had the most actual changes which I'm most unsure about and haven't yet manually tested.

edit: Ok yeah I tested it, seems to work.

Da-Colon · 2025-02-07T04:04:30Z

This also fixes an issue that was found when doing a subgraph lookup on polygon https://linear.app/decent-labs/issue/ENG-182/deployed-a-polygon-dao-does-not-load

linear · 2025-02-07T05:48:55Z

ENG-182 Deployed a Polygon DAO. Does not load.

adamgall added 3 commits February 3, 2025 10:58

Remove a bunch of graphql / apollo stuff from package.json

fac0260

Install urql and graphql packages

5c2d4a4

First pass through of replacing apollo with urql

d35d015

adamgall self-assigned this Feb 3, 2025

adamgall requested review from Da-Colon, mudrila, johnqh and DarksightKellar February 3, 2025 21:06

DarksightKellar reviewed Feb 4, 2025

View reviewed changes

src/graphql/index.ts Outdated Show resolved Hide resolved

src/components/DaoHierarchy/DaoHierarchyNode.tsx Outdated Show resolved Hide resolved

adamgall added 10 commits February 4, 2025 10:05

Remove some more apollo specific configs

daa7538

Add more Decent and Sablier config data to the network config files

fa72e20

Refactor GraphQL client creation and remove URQL provider

fb5481b

Merge branch 'develop' into ENG-61_update-subgraph-endpoints

6208a14

Remove network-only request policy from GraphQL queries

2380ba3

Update GraphQL query names and imports across multiple files

1548b20

- Renamed GraphQL query constants from *QueryDocument to *Query - Updated import statements in various files to use new query names - Affected files include DaoHierarchyNode, DAOQueries, StreamsQueries, and several hooks

Rename subgraph configuration type and update network configs

b3e7cae

- Renamed `SubgraphConfig` to `TheGraphConfig` in types - Updated network configs to use `decentSubgraph` instead of `subgraph` - Modified GraphQL client creation to use the new configuration type

Remove version from TheGraphConfig and update subgraph URLs

a4d2cac

- Removed `version` field from TheGraphConfig type - Updated GraphQL client creation to use 'version/latest' for dev environments - Removed version configurations from all network config files

adamgall marked this pull request as ready for review February 4, 2025 19:11

adamgall added 2 commits February 4, 2025 14:37

Merge branch 'develop' into ENG-61_update-subgraph-endpoints

003cfc1

Update Sepolia Decent Subgraph ID

a851c43

adamgall requested a review from DarksightKellar February 4, 2025 20:10

adamgall added 2 commits February 4, 2025 15:32

Rename Subgraph API Key Environment Variable

624b344

- Update `.env` and `vite-env.d.ts` to use `VITE_APP_THEGRAPH_API_KEY` - Modify GraphQL client creation to use the renamed environment variable - Consistent naming for TheGraph API key across the application

Remove redundant build script for Cloudflare

95004a5

Da-Colon reviewed Feb 4, 2025

View reviewed changes

Da-Colon mentioned this pull request Feb 4, 2025

[ENG-165] Attempted fix for the issue of setting incorrect governance type #2706

Open

adamgall force-pushed the ENG-61_update-subgraph-endpoints branch from b744035 to 406b343 Compare February 5, 2025 03:25

Da-Colon approved these changes Feb 5, 2025

View reviewed changes

Merge branch 'develop' into ENG-61_update-subgraph-endpoints

3b3066f

DarksightKellar approved these changes Feb 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eng 61 update subgraph endpoints #2708

Eng 61 update subgraph endpoints #2708

adamgall commented Feb 3, 2025 •

edited

Loading

linear bot commented Feb 3, 2025

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading

Da-Colon Feb 4, 2025

Da-Colon Feb 4, 2025

Da-Colon Feb 4, 2025

adamgall Feb 5, 2025

Da-Colon Feb 4, 2025

Da-Colon Feb 4, 2025

adamgall Feb 5, 2025

adamgall Feb 5, 2025

Da-Colon Feb 4, 2025

adamgall Feb 5, 2025

Da-Colon left a comment

adamgall commented Feb 5, 2025 •

edited

Loading

Da-Colon commented Feb 7, 2025

linear bot commented Feb 7, 2025

		// eslint-disable-next-line react-hooks/exhaustive-deps
		}, []);

Eng 61 update subgraph endpoints #2708

Are you sure you want to change the base?

Eng 61 update subgraph endpoints #2708

Conversation

adamgall commented Feb 3, 2025 • edited Loading

linear bot commented Feb 3, 2025

cloudflare-workers-and-pages bot commented Feb 3, 2025 • edited Loading

Deploying decent-interface with Cloudflare Pages

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Da-Colon left a comment

Choose a reason for hiding this comment

adamgall commented Feb 5, 2025 • edited Loading

Da-Colon commented Feb 7, 2025

linear bot commented Feb 7, 2025

adamgall commented Feb 3, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading

adamgall commented Feb 5, 2025 •

edited

Loading