Gasless voting UI #2692
Gasless voting UI #2692
Conversation
Deploying decent-interface with
|
| Latest commit: |
efd973f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d22099e8.decent-interface.pages.dev |
| Branch Preview URL: | https://eng-25-gassless-voting-ui.decent-interface.pages.dev |
DarksightKellar
requested review from
mudrila,
Da-Colon,
adamgall,
johnqh and
a team
and removed request for
mudrila and
Da-Colon
src/components/DaoCreator/formComponents/AzoriusTokenDetails.tsx
Outdated
Show resolved
Hide resolved
DarksightKellar
force-pushed
the
eng-25-gassless-voting-ui
branch
from
0b38204 to
d168e33
Compare
|
Gonna mark this as draft since there's a number of unresolved points pending input |
|
@DarksightKellar The button seems very small and looks weird bellow the divider. @nicolaus-sherrill will be able to give you more input. |
…ag and gas tank address from external source of truth
@nicolaus-sherrill
|
There was a problem hiding this comment.
@DarksightKellar this looks great for setup. High-fidelity UI is incoming today.
| <Button | ||
| variant="secondary" | ||
| leftIcon={<Icon as={GasPump} />} | ||
| onClick={() => { | ||
| console.log( | ||
| 'addGas. Add this action to the proposal, to be submitted via propose changes button.', | ||
| ); | ||
|
|
||
| // @todo: Add UI to set the amount, then call onGasTankTopupAmountChange. | ||
| props.onGasTankTopupAmountChange({ | ||
| value: '1', | ||
| bigintValue: 1n, | ||
| }); | ||
| }} | ||
| > | ||
| {t('addGas')} | ||
| </Button> |
There was a problem hiding this comment.
So this button is so that a proposal is created to fund the gas tank via a proposal?
There was a problem hiding this comment.
The way I see it, the end result of this button is a prepared transaction to fund the tank. The "Propose" button will have to be clicked at the bottom for the proposal to be prepared and submitted
| if (gaslessVotingChanged) { | ||
| changeTitles.push(t('enableGaslessVoting', { ns: 'proposalMetadata' })); | ||
|
|
||
| // @todo Is KV pairs the place we're storing this flag? |
There was a problem hiding this comment.
Thats a good question? Probably right?
…ToggleDAOCreate` and `GaslessVotingToggleDAOSettings`
Closes ENG-25
Closes ENG-153
DAO settings:
Create DAO flow
Design (implemented in a previous commit):
Implemented currently:
See this comment
See issue for testing instructions