Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-113 | Wallet-Client] Swap useWalletClient for useNetworkWalletClient #2678

Merged
merged 12 commits into from
Jan 22, 2025

Conversation

Da-Colon
Copy link
Contributor

@Da-Colon Da-Colon commented Jan 17, 2025

Part 1 of 3.
- Swap Public Client
- Swap Wallet Client <------
- Find and Update any other hooks

This PR swaps out wagmi's useWalletClient with @adamgall 's implementation that extends the 'writeandsendTransaction function to switchChain to the network set by the client (coming from the network config store)

Other Updates

  • Updates the useWaletClient to useNetworkWalletClient

Copy link

linear bot commented Jan 17, 2025

Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2025

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2fb363
Status: ✅  Deploy successful!
Preview URL: https://537122ec.decent-interface.pages.dev
Branch Preview URL: https://use-walet-client.decent-interface.pages.dev

View logs

@Da-Colon Da-Colon changed the title [ENG-113-Wallet-Client] Swap useWalletClient for useNetworkWalletClient [ENG-113 | Wallet-Client] Swap useWalletClient for useNetworkWalletClient Jan 17, 2025
@Da-Colon Da-Colon changed the base branch from develop to eng-113-swap-usePublicClient January 17, 2025 04:14
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you done some transactions? Do things work as expected so far?

@Da-Colon
Copy link
Contributor Author

Have you done some transactions? Do things work as expected so far?

Yep several in a few different places, everything seems to be working as expected

Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but left a question

src/hooks/useNetworkWalletClient.ts Show resolved Hide resolved
@Da-Colon Da-Colon merged commit 198330b into eng-113-swap-usePublicClient Jan 22, 2025
4 checks passed
@Da-Colon Da-Colon deleted the use-walet-client branch January 22, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants