[Cloudflare] New Demo Mode #2668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
force-pushed
the
cf/cloudflare-functions-client
branch
from
d5c6a12 to
0cf5ffa
Compare
adamgall
force-pushed
the
cf/new-demo-mode
branch
from
46bb520 to
0cea7fc
Compare
Deploying decent-interface with
|
| Latest commit: |
33d777f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://85aeb14c.decent-interface.pages.dev |
| Branch Preview URL: | https://cf-new-demo-mode.decent-interface.pages.dev |
adamgall
force-pushed
the
cf/cloudflare-functions-client
branch
from
0cf5ffa to
96cc865
Compare
adamgall
force-pushed
the
cf/new-demo-mode
branch
from
0cea7fc to
b5e6d69
Compare
src/hooks/utils/useDemoMode.ts
Outdated
There was a problem hiding this comment.
I sense the beginnings of an expansion of John's feature flag work in this file to account for persistence. If true, I likey.
There was a problem hiding this comment.
Yo this is dope now check it out
adamgall
force-pushed
the
cf/cloudflare-functions-client
branch
from
96cc865 to
bc8c422
Compare
adamgall
force-pushed
the
cf/new-demo-mode
branch
from
b5e6d69 to
49e2afb
Compare
@johnqh not sure I follow your suggestion here. My own preference would be to continue merging this as-is (apart from any PR review of course), so that we don't lose the ability for Parker to give demos, and then deal with the merge conflicts from #2648 when they happen. |
DarksightKellar
requested changes
Jan 15, 2025
DarksightKellar
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer have a dedicated "demo" environment in Cloudflare (all "non production environments" are the same), we need a new way to use Demo Mode.
This PR is an answer to that.
It's implemented via a
demo_modequery param.Please append the
demo_mode=onquery param to a url in the URL bar to "turn on" demo mode for any deployment.Ex:
Also includes a button in the footer to turn it off, if it's on.
This PR also removes the
isDevMode()functionality from the codebase. If this is being used on any @decentdao/engineering machines let me know and we can add it back in.