Create pagination on home page proposals list #2655
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Holy hell, what? This has gotta be the best ad for Cursor yet. |
|
Cursor loves working in React codebases. |
| icon: ComponentType; | ||
| } | ||
|
|
||
| function NavButton({ onClick, isDisabled, icon: IconComponent }: NavButtonProps) { |
There was a problem hiding this comment.
Why just not naming it IconComponent right on the interface?
src/hooks/utils/usePagination.ts
Outdated
|
|
||
| const [pageSize, setPageSize] = useState(() => { | ||
| const size = searchParams.get(QUERY_PARAMS.SIZE); | ||
| return size && PAGE_SIZE_OPTIONS.includes(parseInt(size)) ? parseInt(size) : DEFAULT_PAGE_SIZE; |
There was a problem hiding this comment.
Might as well parseInt on searchParams.get(QUERY_PARAMS.SIZE) instead. Also worried about QUERY_PARAMS having non-numeric values
There was a problem hiding this comment.
I've cleaned up the query param validation and making sure weird user input (via query params in url) are handled properly. Please try to break it yourself!
Deploying decent-interface with
|
| Latest commit: |
7095513
|
| Status: | 🚫 Build failed. |
|
Bug I noticed while David was screensharing and testing. When a list of proposals is being loaded for the first time, the "last item" on the first page will get stuck on a "loading" component. |
…tual proposals loading in
Closes https://linear.app/decent-labs/issue/ENG-108/create-pagination-controls-for-proposals-list
I wanted it to exist, so I told the AI to do it, and it did.
Will create PM artifacts in the AM.