Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for #907 #976

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Fixes for #907 #976

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0751214
Fix for #907
jimmaaay Jan 2, 2018
98a0ba5
Added fix for toolbar switch button
jimmaaay Jan 2, 2018
794040a
use flex centering to fix firebox positioning bug
erquhart Jan 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Collection/Sidebar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
& input {
background-color: #eff0f4;
border-radius: var(--borderRadius);

height: 36px; /* issue #907 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this was 36.8px, can you adjust it a bit?

font-size: 14px;
padding: 10px 6px 10px 32px;
width: 100%;
Expand All @@ -39,6 +39,7 @@
position: absolute;
left: 6px;
z-index: 2;
top: 9px; /* issue #907 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this was 9.4px, can you adjust it a bit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather avoid partial pixels, and I also want to avoid locking down all browsers to this solution if possible. Taking a quick look locally.

}
}

Expand Down
1 change: 1 addition & 0 deletions src/components/UI/Toggle/Toggle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
@apply(--dropShadowDeep);
position: absolute;
left: 0;
top: 0; /* Fix 907 */
width: 20px;
height: 20px;
border-radius: 50%;
Expand Down